Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Rewards bitFlyer external wallets #14591

Closed
zenparsing opened this issue Mar 9, 2021 · 1 comment · Fixed by brave/brave-core#8191
Closed

Add support for Rewards bitFlyer external wallets #14591

zenparsing opened this issue Mar 9, 2021 · 1 comment · Fixed by brave/brave-core#8191
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.24.x - Release

Comments

@zenparsing
Copy link

zenparsing commented Mar 9, 2021 •
edited by LaurenWags
Loading

Test Plan

https://github.com/brave/internal/issues/765
@zenparsing zenparsing mentioned this issue Mar 9, 2021
Merged
24 tasks
@zenparsing zenparsing added this to the 1.24.x - Beta milestone Apr 7, 2021
@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Test-All-Platforms labels Apr 19, 2021
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 30, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Apr 30, 2021 •
edited by stephendonner
Loading

Verifications completed over multiple versions, but most recently using:

Brave	1.24.81 Chromium: 90.0.4430.93 (Official Build) (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 10.15.7 (Build 19H1030)

Test notes, screenshots, and issues found during testing are listed under https://github.com/brave/internal/issues/765#issuecomment-824362121

Verification passed on

Brave 1.24.81 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Ubuntu 18.04 LTS

Verification done in https://github.com/brave/internal/issues/765#issuecomment-830696815

Verification passed on

Brave | 1.24.82 Chromium: 90.0.4430.93 (Official Build) (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verification done in https://github.com/brave/internal/issues/765#issuecomment-826932465

Verification passed on

Brave 1.24.76 Chromium 90.0.4430.85 and 1.24.82 on Android 9 and 10, respectively.

Verification done in https://github.com/brave/internal/issues/765#issuecomment-832093271 and https://github.com/brave/internal/issues/765#issuecomment-831358684

@LaurenWags LaurenWags mentioned this issue May 4, 2021
Closed
@LaurenWags LaurenWags mentioned this issue May 4, 2021
Closed
This was referenced May 10, 2021
Closed
Closed
@Miyayes Miyayes mentioned this issue Sep 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Add support for Rewards bitFlyer external wallets brave/brave-core
6 participants
@stephendonner @zenparsing @srirambv @LaurenWags @btlechowski @GeetaSarvadnya