Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptowallet info bar points to Extensions instead of Wallet settings #14619

Closed
srirambv opened this issue Mar 10, 2021 · 1 comment · Fixed by brave/brave-core#8204
Closed

Comments

@srirambv
Copy link
Contributor

Description

Cryptowallet info bar points to Extensions instead of Wallet settings

Steps to Reproduce

  1. Install 1.22.49 beta build
  2. Visit Cryptokitties.com and trigger first install info bar
  3. Create CW and close browser
  4. Restart the browser and load cryptokitties.co to trigger CW info bar that has settings button
  5. Click on settings load brave://settings/extensions instead of brave://settings/wallet

Actual result:

CW.Settings.Infobar.mov

Expected result:

Should load brave://settings/wallet and not extensions

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.22.49 Chromium: 89.0.4389.72 (Official Build) beta (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes but expected as change is in for 1.22.x
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @bbondy

@stephendonner
Copy link

stephendonner commented Mar 12, 2021

Verified FIXED on nightly using the inline steps to reproduce/verify, with

Brave 1.23.35 Chromium: 89.0.4389.86 (Official Build) nightly (x86_64)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS macOS Version 11.2.3 (Build 20D91)

Settings now correctly points to brave://settings/wallet.

cryptowallet


Verification passed on


Brave | 1.22.63 Chromium: 89.0.4389.90 (Official Build) dev (64-bit)
-- | --
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | Windows 10 OS Version 2004 (Build 19041.867)


  • Verified the STR from the description and ensured that click on settings redirected to brave://settings/wallet
    image

Verification passed on

Brave 1.22.58 Chromium: 89.0.4389.86 (Official Build) beta (64-bit)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description and ensured that click on settings redirected to brave://settings/wallet
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment