postclick conversion is triggered after view event

[btlechowski]

view event is enough to trigger postclick conversion

Steps to Reproduce

For notification ad follow test case: postclick - notification ad - before click from https://github.com/brave/internal/issues/758
For NTP SI ad follow test case: postclick - NTP SI ad - before click from https://github.com/brave/internal/issues/758
For promoted content ad follow test case: postclick - promoted content - before click from https://github.com/brave/internal/issues/758

Note: The conversion is also triggered for click event event when view event has not been triggered(#14420)

Actual result:

postclick conversion is triggered after view event

postclick - notification ad - before click
Conversion triggered without actual click

[7038:7038:0317/210935.410238:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 9:09 PM
[7038:7038:0317/210935.418435:VERBOSE6:conversions.cc(275)] Successfully logged conversion event

postclick - NTP SI ad - before click
Verified the ad was shown:

[14973:14973:0317/225802.347251:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event

The conversion was triggered after a view event

[14973:14973:0317/225829.249135:VERBOSE1:conversions.cc(224)] Conversion for campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 10:58 PM
[14973:14973:0317/225829.263312:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[14973:14973:0317/225829.284768:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[14973:14973:0317/225829.285722:VERBOSE1:conversions.cc(399)] Convert campaign id d4d0474c-277a-4714-b25d-7b484cdb580a, creative set id 0a697a3b-233a-44bc-a337-e2441fb277a7, creative instance id ed6c467a-8643-42eb-a7cd-32e878fa3cd4 and advertiser id  in 0 hours, 5 minutes, 10 seconds at 11:03 PM

postclick - promoted content - before click
Verified ad was viewed:

[18936:18936:0317/233144.172783:VERBOSE3:promoted_content_ad_event_viewed.cc(24)] Viewed promoted content ad with uuid e426ece0e0877914dda33b76922bcf443e211995b4c7d347e01d2ec2641293da and creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690
[18936:18936:0317/233144.182363:VERBOSE6:promoted_content_ad_event_viewed.cc(32)] Successfully logged promoted content ad viewed event

Conversion was triggered

[18936:18936:0317/233209.888879:VERBOSE1:conversions.cc(224)] Conversion for campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 0 minutes, 0 seconds at 11:32 PM
[18936:18936:0317/233209.894258:VERBOSE6:conversions.cc(275)] Successfully logged conversion event
[18936:18936:0317/233209.898576:VERBOSE3:conversions.cc(295)] Successfully appended conversion to queue
[18936:18936:0317/233209.899808:VERBOSE1:conversions.cc(399)] Convert campaign id 84dd294c-f4c1-4bc0-a232-499c5310ef4c, creative set id f6230b39-ff52-440a-b827-b9db9d06444a, creative instance id 40a69fa9-3814-4ec4-bee8-a176c8fb4690 and advertiser id  in 0 hours, 9 minutes, 56 seconds at 11:42 PM

Expected result:

postclick conversion is not triggered after view event

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave	1.22.62 Chromium: 89.0.4389.90 (Official Build) beta (64-bit)
Revision	62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS	Ubuntu 18.04 LTS

cc @tmancey @moritzhaller @jsecretan @rebron @brave/legacy_qa

[GeetaSarvadnya]

Reproduced in Windows 10 x64 - 1.22.64. The issue is reproduced for the following test cases

postclick - notification ad - before click
postclick - NTP SI ad - before click

[btlechowski]

Verification passed on

Brave	1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	Ubuntu 18.04 LTS

Verified selected test cases from https://github.com/brave/internal/issues/758

postclick - notification ad - before click

[7189:7189:0421/160323.268495:VERBOSE1:conversions.cc(206)] Checking URL for conversions
[7189:7189:0421/160323.273245:VERBOSE1:purchase_intent_processor.cc(95)] No purchase intent matches found for visited URL
[7189:7189:0421/160323.306776:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software
[7189:7189:0421/160323.311570:VERBOSE1:conversions.cc(268)] No conversions found for visited URL

postclick - notification ad - after click

[7984:7984:0421/160759.109838:VERBOSE1:conversions.cc(289)] Conversion for campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id c7e7a381-4c74-4dd9-9b6d-4edf9330454b, creative instance id 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 on Wednesday, April 21, 2021 at 4:07:59 PM

postclick - NTP SI ad - before click

[9289:9289:0421/161438.452433:VERBOSE6:new_tab_page_ad_event_viewed.cc(32)] Successfully logged new tab page ad viewed event
[9289:9289:0421/161505.976255:VERBOSE1:conversions.cc(206)] Checking URL for conversions
[9289:9289:0421/161505.988861:VERBOSE1:purchase_intent_processor.cc(95)] No purchase intent matches found for visited URL
[9289:9289:0421/161505.991674:VERBOSE1:text_classification_processor.cc(62)] Classified text with the top segment as technology & computing-software
[9289:9289:0421/161506.016180:VERBOSE1:conversions.cc(268)] No conversions found for visited URL

postclick - NTP SI ad - after click

[9289:9289:0421/161619.838804:VERBOSE6:new_tab_page_ad_event_clicked.cc(33)] Successfully logged new tab page ad clicked event
[9289:9289:0421/161640.122351:VERBOSE1:conversions.cc(289)] Conversion for campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id c7e7a381-4c74-4dd9-9b6d-4edf9330454b, creative instance id 54592ab6-5a8e-42e6-8e11-9e9c04e9eecb and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 on Wednesday, April 21, 2021 at 4:16:40 PM
[9289:9289:0421/161640.135165:VERBOSE6:conversions.cc(342)] Successfully logged conversion event

[btlechowski]

Blocked till news feed is working on staging and dev

[btlechowski]

Removed QA/Blocked as it was decided that we don't need to test promoted content ads