Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use compile-time vars for rewards Uphold settings #14900

Closed
zenparsing opened this issue Mar 23, 2021 · 3 comments · Fixed by brave/brave-core#8380
Closed

Use compile-time vars for rewards Uphold settings #14900

zenparsing opened this issue Mar 23, 2021 · 3 comments · Fixed by brave/brave-core#8380

Comments

@zenparsing
Copy link

Uphold settings used by bat-native-ledger should be specified using compile-time variables.

@stephendonner
Copy link

Verified PASSED using 1.24 (beta) with the testplan from brave/brave-core#8380

Steps:

  1. Started browser with ./Brave\ Browser\ Beta --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=4
  2. Verified wallet and ensured that there were no errors (after enabling Rewards and accepting UGP grant)
  3. Ensured that we connected to Uphold's staging server (https://wallet-sandbox.uphold.com/authorize/...)
  4. Started browser with ./Brave\ Browser\ Beta --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-debug --rewards=staging=false,reconcile-interval=4
  5. Verified wallet and ensured that there were no errors
  6. Ensured that we connected to Uphold's production server
example example example example example example example example example example example
Screen Shot 2021-04-20 at 1 48 15 PM Screen Shot 2021-04-20 at 1 48 29 PM Screen Shot 2021-04-20 at 1 48 36 PM Screen Shot 2021-04-20 at 1 49 15 PM Screen Shot 2021-04-20 at 1 49 28 PM Screen Shot 2021-04-20 at 1 55 29 PM Screen Shot 2021-04-20 at 1 55 50 PM Screen Shot 2021-04-20 at 1 58 40 PM Screen Shot 2021-04-20 at 2 30 13 PM Screen Shot 2021-04-20 at 2 30 24 PM Screen Shot 2021-04-20 at 2 30 32 PM

@kjozwiak
Copy link
Member

QA we'll only be able to check the Staging case on Android as there's no way for us to get a production grant so we can meet the 15 BAT limitation before creating an Uphold account. However, we need to wait till we get the RC uploaded by @SergeyZhukovsky into the BETA program as claiming grants doesn't work when you upload the aab via the internal sharing tool. Once we get the new RC, we'll ask @SergeyZhukovsky to upload and should be able to QA this quickly.

@stephendonner
Copy link

stephendonner commented May 11, 2021

Verified PASSED on staging for Android 9, Google Pixel XL, with Brave 1.24.84, Chromium 90.0.4430.93, using the testplan from brave/brave-core#8380

Steps:

  1. enabled verbose logging and Rewards staging via the QA Preferences menu, in Developer Options
  2. restarted Brave
  3. claimed UGP grant on staging of 30.000 BAT
  4. connected to and verified my Uphold wallet

Confirmed we use Uphold's sandbox staging env:

 [ RESPONSE - OnRequest ]
    > Url: https://api-sandbox.uphold.com/v0/me/cards?q=currency:BAT
    > Result: Success
    > HTTP Code: 200
    > Body: [{"CreatedByApplicationId":"193a77cf-02e8-4e10-8127-8a1b5a8bfece","address":{"wire":"UH35E32B4B"},"available":"998.00","balance":"998.00","currency":"BAT","id":"XXXXXXXXXXXX","label":"Brave Browser","lastTransactionAt":"2021-04-30T20:08:39.417Z","settings":{"position":1,"protected":false,"starred":true},"normalized":[{"available":"1344.32","balance":"1344.32","currency":"USD"}],"wire":[{"accountName":"Uphold Europe Limited","address":{"line1":"Tartu mnt 2","line2":"10145 Tallinn, Estonia"},"bic":"LHVBEE22","currency":"EUR","iban":"EE76 7700 7710 0159 0178","name":"AS LHV Pank"},{"accountName":"Uphold HQ, Inc.","accountNumber":"299007316","address":{"line1":"99 Park Avenue, Floor 4","line2":"New York, NY 10016"},"bic":"MCBEUS33","currency":"USD","name":"Metropolitan Commercial Bank","routingNumber":"XXXXX"}]}
example example example example example
Screenshot_20210511-114837 Screenshot_20210511-114856 Screenshot_20210511-115203 Screenshot_20210511-115324 Screenshot_20210511-115331

Verification PASSED on Samsung Galaxy Tablet A running Android 10 using the following build:

1.24.84, Chromium 90.0.4430.93
Rewards Log
[ RESPONSE - OnRequest ]
    > Url: https://api-sandbox.uphold.com/v0/me/cards/3ada831b-1a43-43c2-bfe7-a8edd1c9491f
    > Result: Success
    > HTTP Code: 200
    > Body: {"CreatedByApplicationId":"193a77cf-02e8-4e10-8127-8a1b5a8bfece","address":{"wire":"UH36394F14"},"available":"198.25","balance":"198.25","currency":"BAT","id":"3ada831b-1a43-43c2-bfe7-a8edd1c9491f","label":"Brave Browser","lastTransactionAt":"2021-04-20T04:04:47.941Z","settings":{"position":1,"protected":false,"starred":true},"normalized":[{"available":"324.58","balance":"324.58","currency":"CAD"}],"wire":[{"accountName":"Uphold Europe Limited","address":{"line1":"Tartu mnt 2","line2":"10145 Tallinn, Estonia"},"bic":"LHVBEE22","currency":"EUR","iban":"EE76 7700 7710 0159 0178","name":"AS LHV Pank"},{"accountName":"Uphold HQ, Inc.","accountNumber":"xxxxxxx","address":{"line1":"99 Park Avenue, Floor 4","line2":"New York, NY 10016"},"bic":"MCBEUS33","currency":"USD","name":"Metropolitan Commercial Bank","routingNumber":"xxxxxxx"}]}
Example Example Example Example Example
Screenshot_20210511-154016_Brave Screenshot_20210511-154035_Brave Screenshot_20210511-154039_Brave Screenshot_20210511-154109_Brave Screenshot_20210511-154357_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants