Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only apply top level domain blocking in aggressive mode, by default #15095

Closed
pes10k opened this issue Apr 2, 2021 · 2 comments · Fixed by brave/brave-core#8470
Closed

Only apply top level domain blocking in aggressive mode, by default #15095

pes10k opened this issue Apr 2, 2021 · 2 comments · Fixed by brave/brave-core#8470
Assignees
@pilgrim-brave
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA/No release-notes/include
Milestone
1.24.x - Release

Comments

@pes10k
Copy link
Contributor

pes10k commented Apr 2, 2021

Currently, when top level domain blocking is enabled, its applied regardless of other shields settings. This issue is to have top level domain blocking be applied in the "aggressive" tracker blocking configuration.

Note: this may be changed in the v2 version of the feature, where we have the ability to automatically follow / debounce well known tracking URLs
@pes10k pes10k added privacy privacy/feature User-facing privacy- & security-focused feature work. OS/Android Fixes related to Android browser functionality privacy-pod Feature work for the Privacy & Web Compatibility pod OS/Desktop labels Apr 2, 2021
@pes10k pes10k mentioned this issue Apr 2, 2021
Open
@pilgrim-brave pilgrim-brave mentioned this issue Apr 7, 2021
Merged
24 tasks
@kjozwiak kjozwiak added this to the 1.25.x - Nightly milestone Apr 8, 2021
@brave-builds brave-builds mentioned this issue Apr 8, 2021
Merged
7 tasks
@kjozwiak kjozwiak mentioned this issue Apr 12, 2021
Closed
@kjozwiak
Copy link
Member

We'll use #15242 for verifications 👍

@LaurenWags LaurenWags mentioned this issue May 4, 2021
Closed
@LaurenWags
Copy link
Member

changing to release-notes/include per discussion with @rebron and @kjozwiak

This was referenced May 10, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA/No release-notes/include
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Only apply top level domain blocking in aggressive mode brave/brave-core
4 participants
@pes10k @kjozwiak @LaurenWags @pilgrim-brave