Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Upgrade connections to HTTPS" is on but shown as off #15319

Open
fabi-hub opened this issue Apr 15, 2021 · 7 comments
Open

"Upgrade connections to HTTPS" is on but shown as off #15319

fabi-hub opened this issue Apr 15, 2021 · 7 comments
Labels
bug feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields feature/shields The overall Shields feature in Brave. needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@fabi-hub
Copy link

fabi-hub commented Apr 15, 2021

Description

When I clear browsing data "Site and Shield Settings". The setting "Upgrade connections to HTTPS" is on again (like it should be), but in the Settings it is shown as disabled, while in Shield is shown as "on".

Steps to Reproduce

Turn "Upgrade connections to HTTPS" off.
Clear browsing data and make sure "Site and Shield Settings" is checked.

When done the Settings looks like this:
settings

And in Shield it looks like this:
shield

Expected result:

Orange dot in the settings

Brave version (brave://version info)

Brave 1.25.16 Chromium: 90.0.4430.70 (Official Build) nightly (64-bit)
Revision 3954de7175366f3b7edca576f140dfa273e6b5ae-refs/branch-heads/4430@{#1210}
OS Windows 10 OS Version 2009 (Build 19042.906)
JavaScript V8 9.0.257.16
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.70 Safari/537.36

Version/Channel Information:

I testet Nightly and Final, both have this bug

@rebron rebron added needs-investigation A bug not 100% confirmed/fixed feature/shields The overall Shields feature in Brave. labels Apr 16, 2021
@rebron
Copy link
Collaborator

rebron commented Apr 16, 2021

cc: @srirambv Can you double check this for me? I think this is a wontfix
@fabi-hub I can see the confusion. This is expected behavior since clearing browsing data for "Shields and Site Settings" clears the specific shield settings say for example a duckduckgo.com or other set of websites where you made changes.

It's not going to reset settings on this page, that would be here: brave://settings/reset

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Apr 16, 2021
@fabi-hub
Copy link
Author

ah okay, I understand.

I thought, cleaning shield and site settings means they go back to the settings that I have selected in the main settings.

@srirambv
Copy link
Contributor

@rebron I think this is a bug. When we clear site settings it should reset all shields values to default (global and per site settings). So when you disable HTTPS and delete site settings via clear history its resetting to default but in brave://settings/shields its retaining the disabled state. Opening a new site shows HTTPS as enabled (which is correct).

cc: @bridiver

@rebron rebron added feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields priority/P4 Planned work. We expect to get to it "soon". bug QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. priority/P4 Planned work. We expect to get to it "soon". priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 20, 2021
@rebron
Copy link
Collaborator

rebron commented Jul 20, 2021

@srirambv I agree this is a bug. Looks like there is an issue with the Block Scripts preference too. A clear of sites and shields settings should reset that setting too but it doesn't.

@bridiver
Copy link
Contributor

@rebron the default for "Block Scripts" is disabled so that's correct

@bridiver
Copy link
Contributor

I verified with http://https-everywhere.badssl.com/ that the default setting is working correctly and I have a theory of why this might be happening when you clear content settings. Discussing with @bbondy

@jeffmiko
Copy link

I do not have the issue when using an incognito window. I do have the issue with the normal mode.

@rebron rebron moved this to P4 backlog in Settings May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/https-everywhere Issues related to the HTTPS Everywhere component of Shields feature/shields The overall Shields feature in Brave. needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
Status: P4 backlog
Development

No branches or pull requests

5 participants