-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Upgrade connections to HTTPS" is on but shown as off #15319
Comments
cc: @srirambv Can you double check this for me? I think this is a wontfix It's not going to reset settings on this page, that would be here: brave://settings/reset |
ah okay, I understand. I thought, cleaning shield and site settings means they go back to the settings that I have selected in the main settings. |
@rebron I think this is a bug. When we clear site settings it should reset all shields values to default (global and per site settings). So when you disable HTTPS and delete site settings via clear history its resetting to default but in brave://settings/shields its retaining the disabled state. Opening a new site shows HTTPS as enabled (which is correct). cc: @bridiver |
@srirambv I agree this is a bug. Looks like there is an issue with the Block Scripts preference too. A clear of sites and shields settings should reset that setting too but it doesn't. |
@rebron the default for "Block Scripts" is disabled so that's correct |
I verified with http://https-everywhere.badssl.com/ that the default setting is working correctly and I have a theory of why this might be happening when you clear content settings. Discussing with @bbondy |
I do not have the issue when using an incognito window. I do have the issue with the normal mode. |
Description
When I clear browsing data "Site and Shield Settings". The setting "Upgrade connections to HTTPS" is on again (like it should be), but in the Settings it is shown as disabled, while in Shield is shown as "on".
Steps to Reproduce
Turn "Upgrade connections to HTTPS" off.
Clear browsing data and make sure "Site and Shield Settings" is checked.
When done the Settings looks like this:
And in Shield it looks like this:
Expected result:
Orange dot in the settings
Brave version (brave://version info)
Version/Channel Information:
I testet Nightly and Final, both have this bug
The text was updated successfully, but these errors were encountered: