Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Windows installer for brave-core; ensure silent install possible #1538

Closed
bsclifton opened this issue Oct 11, 2018 · 4 comments
Closed

Comments

@bsclifton
Copy link
Member

We'll want to try (via CLI) the stub installer on Windows to ensure we can do a silent install. We can capture the exact shell command ran here too

If (for some reason) we run into problems doing that, we can ask folks who may be familiar with the installer (ex: @simonhong or @emerick) for help 😄

@bsclifton
Copy link
Member Author

Looks like silent install would be done with BraveBrowserBetaSetup.exe /silent /install

However, when running the above it fails for me. If I remove /silent, I can see it's trying to elevate using UAC ☹️ Will reach out to @simonhong for more info

@bsclifton
Copy link
Member Author

bsclifton commented Oct 15, 2018

If I launch using BraveBrowserBetaSetup.exe /install, it comes up with the UAC prompt. I can click No, and it'll allow you to continue (with a user-specific install) which after clicking Yes installs to:
%USERPROFILE%\AppData\Local\BraveSoftware\Brave-Browser-Beta\Application

I'm looking in the source now to try and find more command line options. Would like to do this silently

@bsclifton
Copy link
Member Author

bsclifton commented Oct 15, 2018

OK verified with @simonhong that this will likely need to be done when creating the stub installer. We'll want to have two installers created:

  • regular installer (what we have now)
  • silent installer (which defaults to single user install, because it won't elevate to admin)

At that point, the above args would work (/silent /install) against the silent installer

When generating the installer, we'll need to append the following arg (to allow it to work properly):
needsadmin=False

For example:
./ApplyTag.exe BraveUpdateSetup.exe BraveBrowserDevSetup.exe "appguid={GUID}&appname=NAME&needsadmin=False&lang=en"

@bsclifton
Copy link
Member Author

This is definitely possible. We'll need to change the code creating the Omaha stub installer to allow needsadmin=False. I'm working through that (and automating some of the process) with https://github.com/brave/devops/pull/335

Once a binary is available, it would be installable like so:
BraveBrowserSetupSilent.exe /silent /install

@bbondy bbondy removed this from the Muon => Brave Core migration milestone Oct 30, 2018
@bsclifton bsclifton modified the milestones: 0.57.x - Beta, Dupe / Invalid / Not actionable Nov 29, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants