Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove past data from Monthly Statement (JP region) #15426

Closed
LaurenWags opened this issue Apr 21, 2021 · 1 comment · Fixed by brave/brave-core#8618
Closed

remove past data from Monthly Statement (JP region) #15426

LaurenWags opened this issue Apr 21, 2021 · 1 comment · Fixed by brave/brave-core#8618

Comments

@LaurenWags
Copy link
Member

Description

Monthly Statement data prior to April for JP region should be removed as it was in BAP. Going forward data will be in BAT.

Steps to Reproduce

  1. Have a profile with data prior to April 2021
  2. Upgrade to 1.24.x with bF enabled
  3. View Monthly Statement

Actual result:

BAP data displayed on statement

Expected result:

No BAP data should be shown, only BAT data

Reproduces how often:

Brave version (brave://version info)

1.24.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? 1.24.x yes
  • Can you reproduce this issue with the nightly channel? 1.25.x yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @zenparsing @emerick

@LaurenWags
Copy link
Member Author

LaurenWags commented May 7, 2021

Verified passed with

Brave | 1.24.83 Chromium: 90.0.4430.93 (Official Build) (x86_64)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | macOS Version 10.15.7 (Build 19H1030)
Japan region

Using 1.24.82 confirmed that March displays in Monthly Statement w/ data and the balance_report_info table shows March:

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
1 2 3 4

Upgraded to 1.24.83.
Confirmed that March no longer shows in the Monthly Statement.
Confirmed that previous balance_report_info table was archived to balance_report_info_bap.
Confirmed that new balance_report_info does not show March.

Monthly Statement balance_report_info_bap balance_report_info table
5 6 7
US region

Generally confirmed US monthly statement is unaffected by this fix with the below:

Using 1.24.82 confirmed that March displays in Monthly Statement w/ data and the balance_report_info table shows March:

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
1 2 3 4

Upgraded to 1.24.83.
Confirmed that March still shows in the Monthly Statement.
Confirmed that previous balance_report_info table was not archived to balance_report_info_bap.
Confirmed that balance_report_info continues to show March data.

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
5 6 7 8

Verification passed on


Brave | 1.24.83 Chromium: 90.0.4430.93 (Official Build) (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)


Japan region

Using 1.23.71 confirmed that March displays in Monthly Statement w/ data and the balance_report_info table shows March:

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
image image image image

Using 1.24.82 confirmed that March displays in Monthly Statement w/ data and the balance_report_info table shows March:

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
image image image image

Upgraded to 1.24.83.
Confirmed that March no longer shows in the Monthly Statement.
Confirmed that previous balance_report_info table was archived to balance_report_info_bap.
Confirmed that new balance_report_info does not show March.

Monthly Statement balance_report_info_bap balance_report_info table
image image image
IN region

Generally confirmed IN monthly statement is unaffected by this fix with the below:

Using 1.24.82 confirmed that March displays in Monthly Statement w/ data and the balance_report_info table shows March:

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
image image image image

Upgraded to 1.24.83.
Confirmed that March still shows in the Monthly Statement.
Confirmed that previous balance_report_info table was not archived to balance_report_info_bap.
Confirmed that balance_report_info continues to show March data.

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
image image image image

Verification passed on

Brave 1.24.83 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Ubuntu 18.04 LTS
Japan region

Using 1.24.82 confirmed that March displays in Monthly Statement w/ data and the balance_report_info table shows March:

Monthly Statement Monthly Statement balance_report_info table
image image image

Upgraded to 1.24.83.
Confirmed that March no longer shows in the Monthly Statement.
Confirmed that previous balance_report_info table was archived to balance_report_info_bap.
Confirmed that new balance_report_info does not show March.

Monthly Statement balance_report_info_bap balance_report_info table
image image image
PL region

Generally confirmed US monthly statement is unaffected by this fix with the below:

Using 1.24.82 confirmed that March displays in Monthly Statement w/ data and the balance_report_info table shows March:

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
image image image

Upgraded to 1.24.83.
Confirmed that March still shows in the Monthly Statement.
Confirmed that previous balance_report_info table was not archived to balance_report_info_bap.
Confirmed that balance_report_info continues to show March data.

Monthly Statement Monthly Statement Monthly Statement balance_report_info table
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment