Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Android command line handler and fix QA prefs first parameter handling #15540

Closed
goodov opened this issue Apr 28, 2021 · 2 comments · Fixed by brave/brave-core#8659
Closed

Restore Android command line handler and fix QA prefs first parameter handling #15540

goodov opened this issue Apr 28, 2021 · 2 comments · Fixed by brave/brave-core#8659
Assignees
@goodov
Labels
dev-concern dev-experience OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.24.x - Release

Comments

@goodov
Copy link
Member

goodov commented Apr 28, 2021 •
edited
Loading

We implemented a QA interface to ease browser testing process, but the default Android Chromium logic to stub command line doesn't work now.

It would be great to restore Chromium logic and keep the QA interface so they can be used together.

Also currently the QA interface doesn't add _ as a first parameter which leads to the first parameter being ignored. Here are some details.
@goodov goodov self-assigned this Apr 28, 2021
This was referenced Apr 28, 2021
Closed
Merged
@goodov
Copy link
Member Author

goodov commented Apr 28, 2021

QA here is quite simple. We just need to make sure the QA command line dialog works and the verbose AD logs switch also works without issues. And if we set a parameter via QA dialog, it's applied without prepending _ first. So --permission-lifetime-test-seconds=20 should work without issues.

@goodov goodov added this to the 1.25.x - Nightly milestone Apr 28, 2021
@melo936 melo936 mentioned this issue Apr 30, 2021
Closed
@srirambv
Copy link
Contributor

srirambv commented May 3, 2021

Verification passed on OnePlus 6T with Android 10 running 1.24.81 x64 build

  • Verified command line args work as expected

Verification passed on Samsung Tab A with Android 10 running 1.24.81 x64 build

  • Verified command line args work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodov goodov

Labels
dev-concern dev-experience OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Restore Chromium command line handler and fix QA command line append. brave/brave-core
3 participants
@kjozwiak @goodov @srirambv