Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to create wallet needs proper error and chance to retry #1563

Closed
jasonrsadler opened this issue Oct 13, 2018 · 2 comments
Closed

Failing to create wallet needs proper error and chance to retry #1563

jasonrsadler opened this issue Oct 13, 2018 · 2 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@jasonrsadler
Copy link

Description

If an internet connection is not available or there is a server issue, trying to create a wallet will go to a white page with a failed to create wallet error.

When a connection is restored, navigating to chrome://rewards shows the error and does not give another change to create wallet

Steps to Reproduce

  1. Start Brave with clean profile
  2. Disable internet connection
  3. Try to enable rewards
  4. Observe error message
  5. Close Brave and reenable internet connection
  6. Reopen Brave and go to chrome://rewards

Actual result:

Error message about wallet creation failed persists and doesn't give user a chance to create wallet

Expected result:

Opt-in screen should show appropriate error and allow retry to wallet creation

Reproduces how often:

always

Brave version (chrome://version info)

Brave 0.57.1 Chromium: 70.0.3538.54 (Developer Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? tested on Dev
  • Does it reproduce on browser-laptop? NA

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@jasonrsadler jasonrsadler added this to the 1.x Backlog milestone Oct 13, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 19, 2018

@NejcZdovc is this fixed with a recent PR?

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 19, 2018
@NejcZdovc
Copy link
Contributor

yes it was fixed with #1687

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 19, 2018
@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label Oct 19, 2018
@kjozwiak kjozwiak removed feature/rewards priority/P4 Planned work. We expect to get to it "soon". labels Oct 22, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

5 participants