-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote frame is set on ephemeral-storage should-not-keep-alive test; should be empty #15646
Comments
I'm pretty confident this is a general issue and not specific to keepalive. Can you run through the non-keepalive ephemeral storage tests? |
@stephendonner have you checked the non-keepalive tests with keepalive disabled? I don't think this is a keepalive issue, I think it's a regression on android |
Sorry for the delay in responding. Using
|
To provide a little more detail on this, the issue is not related to keep alive. The problem is that the session storage used for ephemeral local storage remained cached in the renderer even after the namespace was deleted in the browser process. It stayed cached across different domains and links and was only purged when typing a url into the urlbar, but only within the same tab which is why https://dev-pages.brave.software/storage/ephemeral-storage.html had the correct results |
also this issue exists in current release 1.24.x |
Verification passed on Samsung Tab A with Android 10 running 1.24.86 x64 build Verified steps from test case mentioned in issue description
Verification passed on OnePlus 6T with Android 10 running 1.24.86 x64 build Verified steps from test case mentioned in issue description
Verification passed on Asus Zenfone (x86) with Android 6 running 1.24.86: Verified the six test configurations from https://dev-pages.brave.software/storage/ephemeral-storage.html:
|
Test Cases:
Note: You'll need to do the following before running through the
ephemeral-storage
checks:brave://version/?show-variations-cmd
(you'll be missing the needed seed)brave://version/?show-variations-cmd
(you should have the needed seed)Once you pull the needed seed from griffin, you'll be able to run through the passes.
Description
Remote frame is set on ephemeral-storage should-not-keep-alive test; should be empty.
Found while testing #15415 as a follow-up to desktop, where it works fine.
Steps to reproduce
brave://flags
and enableEnable Ephemeral Storage
and disableEphemeral Storage Keep Alive
if it's available in the releasehttps://dev-pages.brave.software/storage/keep-alive.html
Start test
button beneath theShould "Keep Alive" Test
Current storage state
, the results forThis frame
andLocal frame
readset
, andRemote frame
should readempty
Actual result
Remote frame
readsset
Expected result
Remote frame
readsempty
Issue reproduces how often
100%
Device details
Brave version
1.25.51, Chromium 90.0.4430.93
/cc @pes10k and @bridiver
The text was updated successfully, but these errors were encountered: