tip banner rewards onboarding tour issues

[LaurenWags]

Description

Rewards onboarding tour via tip banner doesn't match the others (from panel and brave://rewards).

Steps to Reproduce

1. Clean profile, Japan region, if not enabled by default, enable bF.
2. Navigate to a twitter page or other page with in-line tip button
3. Click on on-line tip button
4. On the tip banner, select Start using Brave Rewards
5. View onboarding tour

Actual result:

AC slide is present
Settings slide is present
no bF slide

Expected result:

no AC slide
no Settings slide
bF slide should be present

Reproduces how often:

easily

Brave version (brave://version info)

Brave | 1.24.83 Chromium: 90.0.4430.93 (Official Build) （x86_64）
-- | --
変更履歴 | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | macOS バージョン10.15.7（ビルド19H1030）

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes (may need to enable bF via flags)
• Can you reproduce this issue with the nightly channel? yes (may need to enable bF via flags)

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @Miyayes @zenparsing @emerick @brave/legacy_qa

[GeetaSarvadnya]

Verification passed on

Brave | 1.24.84 Chromium: 90.0.4430.93 (Official Build) (64-bit)
-- | --
Revision | 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS | Windows 10 OS Version 2004 (Build 19041.928)

• Verified the STR from the description

Details

• Confirmed AC slide is not shown in the banner rewards onboarding tour
• Confirmed settings slide is not shown in the banner rewards onboarding tour
• Confirmed bF slide is shown in the banner rewards onboarding tour
• Verified the rewards onboarding tour from BR panel, brave://rewards, Inline tip Rewards button, publisher or site and confirmed no AC slide and no settings slide present in the onboarding tour.

Example	Example	Example	Example	Example	Example	Example	Example

---

Verified passed with

Brave	1.24.84 Chromium: 90.0.4430.93 (Official Build) (x86_64)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	macOS Version 10.15.7 (Build 19H1030)

Verified STR from description for Japan region. Checked English and Japanese languages.
Spot checked other onboarding tours (from panel and brave://rewards) to confirm they contained the expected slides.

Details

Using tip banner from reddit site,

• Confirmed AC slide is not shown in the tip banner rewards onboarding tour
• Confirmed settings slide is not shown in the tip banner rewards onboarding tour
• Confirmed bF slide is shown in the tip banner rewards onboarding tour
• Checked English language for tour

Example	Example	Example	Example	Example	Example	Example

Using tip banner from twitter page,

• Confirmed AC slide is not shown in the tip banner rewards onboarding tour
• Confirmed settings slide is not shown in the tip banner rewards onboarding tour
• Confirmed bF slide is shown in the tip banner rewards onboarding tour
• Checked Japanese language for tour

Example	Example	Example	Example	Example	Example	Example

For US region, confirmed tip banner onboarding tour behaved as expected.

Details

Using tip banner from GitHub page,

• Confirmed AC slide is shown in the tip banner rewards onboarding tour
• Confirmed settings slide is shown in the tip banner rewards onboarding tour
• Confirmed bF slide is not shown in the tip banner rewards onboarding tour

Example	Example	Example	Example	Example	Example	Example	Example

---

Verification passed on

Brave	1.24.84 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision	4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS	Ubuntu 18.04 LTS

• Verified the STR from the description

Details

• Confirmed AC slide is not shown in the banner rewards onboarding tour
• Confirmed settings slide is not shown in the banner rewards onboarding tour
• Confirmed bF slide is shown in the banner rewards onboarding tour
• Verified the rewards onboarding tour from BR panel, brave://rewards, Inline tip Rewards button, publisher or site and confirmed no AC slide and no settings slide present in the onboarding tour.