Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant classes for import #15758

Closed
spylogsster opened this issue May 11, 2021 · 2 comments · Fixed by brave/brave-core#8776
Closed

Remove redundant classes for import #15758

spylogsster opened this issue May 11, 2021 · 2 comments · Fixed by brave/brave-core#8776

Comments

@spylogsster
Copy link

spylogsster commented May 11, 2021

After refactoring from brave/brave-core#8771 we do not need anymore dedicated classes.

Removed File/Text/Directory import classes, use base class instead
Move blob creation to network utilities
Avoid of base::Uretained

Test Case

  • all types of IPFS import should work as expected: images, text, links, files, directories, videos
@stephendonner
Copy link

Marking as QA/Blocked until #15935 is verified fixed.

@stephendonner stephendonner added QA/Blocked QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels May 18, 2021
@stephendonner
Copy link

stephendonner commented May 19, 2021

Marking as QA/Blocked until #15935 is verified fixed.

I conflated issues; this is working just fine, sorry!

Verified PASSED using

Brave 1.26.30 Chromium: 91.0.4472.57 (Official Build) nightly (x86_64)
Revision e3443317fa07f1e9997e4a9c738eddfefc3c0292-refs/branch-heads/4472_54@{#6}
OS macOS Version 11.3.1 (Build 20E241)

Steps:

Image

  • loaded * ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/
  • right-clicked and chose Import to IPFS -> Selected image

Text

  • loaded https://www.lipsum.com/ and scrolled down to the first lorem ipsum paragraph
  • selected it and chose Import to IPFS -> Selected text

Link

  • loaded https://archive.org/web/
  • right-clicked on the Wayback Machine logo and choose Import to IPFS -> Linked content

Video

  • loaded https://upload.wikimedia.org/wikipedia/commons/7/79/Big_Buck_Bunny_small.ogv
  • right-clicked on the video and choose Import to IPFS -> Selected video

File

  • loaded https://www.leaseweb.com/platform/network
  • scrolled down to a 10MB file from a mirror, right-clicked on it and chose Import to IPFS -> Linked content
example example example example example example example
Screen Shot 2021-05-19 at 3 25 03 PM Screen Shot 2021-05-19 at 2 57 09 PM Screen Shot 2021-05-19 at 3 07 31 PM Screen Shot 2021-05-19 at 3 12 48 PM Screen Shot 2021-05-19 at 3 34 26 PM Screen Shot 2021-05-19 at 3 34 31 PM Screen Shot 2021-05-19 at 3 44 40 PM

Image: https://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi.ipfs.dweb.link/?filename=bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi.ipfs.localhost
Text: https://bafybeibjhmwnw2s47sr6xij2xj7thr7u7d3c2v7ckxecvvewolwha6zr3q.ipfs.dweb.link/?filename=www.lipsum.com_13828526949295533255
Link: https://bafybeiavuq4ixeuay3rprg4mb2ydlzmdb3qb3lbjt6b2od5hsiomy65gnq.ipfs.dweb.link/?filename=archive.org **Webpage:** https://bafybeieorrkovrjqdxv24xrvigpotqjljlytwxzubsl6tmh5ejf4fmlqa4.ipfs.dweb.link/?filename=www.wikipedia.org
Video: https://dweb.link/ipfs/QmaNvPDRmgT3xs7E5B9MQoZLxrqMtjfDnWnFrHHhyPzC9i?filename=Big_Buck_Bunny_small.ogv
File: https://dweb.link/ipfs/QmZAjR7E1qB4nD5T55F95thMLn2fG5C8tpUB2FMnVhS8Nn?filename=10mb.bin

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants