Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't show Verified Creator status for Github creators if Private Browsing (Incognito) is launched first #15776

Closed
sgornick opened this issue May 12, 2021 · 2 comments
Labels
closed/by-author feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@sgornick
Copy link

sgornick commented May 12, 2021

Description

Normally, when I load a GitHub profile page, I can click the Brave Rewards triangle to bring up the creator's Brave Creator's profile info (i.e., name, status -- "Not yet verified" / "Brave Verified Creator", option to Send A Tip, etc.). I get different behavior depending on whether I had launched Brave in Private mode (New Incognito Window) first before launching Brave in normal mode (New Window).

Simply having Brave running in Incognito mode first seems to interfere for the normal (non-Incognito) Brave browser window that is launched later, and then in that normal Brave browser windo, no Brave Creator's info will appear -- at least not for a GitHub profile.

Steps to Reproduce

  1. Launch Brave in Private mode (right-click on Brave launcher icon, select New Incognito Windows).
  2. Launch another Brave browser (right-click on Brave launcher icon, select New Window).
  3. Enter in the Address bar: https://github.com/brave (or URL for any Github account profile)
  4. Click on Brave Rewards triangle.

Actual result:

No Brave Creator info.
2021-05-12_07-55

Expected result:

Brave Creator info.
2021-05-12_07-57
(I was able to obtain this image by closing both Brave browser windows, and then launching ONLY Brave once, and in normal mode (right-click on Brave launcher icon, select New Window).

Reproduces how often:

Consistently

Brave version (brave://version info)

Brave 1.24.84 Chromium: 90.0.4430.93 (Official Build) (64-bit)
Revision 4df112c29cfe9a2c69b14195c0275faed4e997a7-refs/branch-heads/4430@{#1348}
OS Linux

Miscellaneous Information:

I tried the same thing with a Twitter account, and am not seeing creator info at all. But then in troubleshooting the Github issue, there was at least once where I saw creator info for the Twitter account. So I don't know whether to combine the Brave Creator info for a Twitter profile (intermittent), with what I'm reporting for this Github Issue. But wanted to mention that as well in case is useful in troubleshooting. It's plausible any fix for the issue showing for the Github profile would also remedy the issue I am having also when showing for a Twitter profile.

@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Aug 25, 2021
@Miyayes
Copy link
Collaborator

Miyayes commented Oct 5, 2021

Check if this persists even after Rewards panel 2.0 #14602.

@sgornick
Copy link
Author

sgornick commented Oct 6, 2021

I haven't monitored this issue since reporting it (in Brave v1.24.84).

Today, checking using Brave v1.30.87, I cannot get the issue to recur.

So if Rewards panel 2.0 is first getting merged in v1.31.x, this would have been fixed prior to Rewards panel 2.0 (or, at least, I do not have an explanation as to why this was occurring consistently with v1.24.84 but now cannot get the problem to recur with v1.30.87 ).

So I am closing this issue, with this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/by-author feature/rewards OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

5 participants