Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JP-related rewards blocks for Android #15786

Closed
zenparsing opened this issue May 12, 2021 · 1 comment · Fixed by brave/brave-core#8775
Closed

Remove JP-related rewards blocks for Android #15786

zenparsing opened this issue May 12, 2021 · 1 comment · Fixed by brave/brave-core#8775
Assignees
@zenparsing
Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.25.x - Release

Comments

@zenparsing
Copy link

All Japan-related Rewards blocks should be removed for Android users.
@zenparsing zenparsing added feature/rewards OS/Android Fixes related to Android browser functionality labels May 12, 2021
@zenparsing zenparsing self-assigned this May 12, 2021
@zenparsing zenparsing mentioned this issue May 12, 2021
Merged
24 tasks
@zenparsing zenparsing added this to the 1.26.x - Nightly milestone May 13, 2021
@brave-builds brave-builds mentioned this issue May 13, 2021
Merged
7 tasks
@kjozwiak kjozwiak mentioned this issue May 18, 2021
Closed
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.25.65 x64 build

Verified test plan from brave/brave-core#8775
  • Verified grants is shown for JP locale
  • Verified able to claim grants
  • Verified wallet updates with UGP grant
  • Verified no mention of BAP Tokens or BAP on rewards panel/onboarding/rewards page/rewards internals page
  • Verified able to perform an one-time tip
  • Verified able to set a recurring tip
  • Verified able to perform a contribution
  • Verified no entry for Verify wallet on BR Panel
image image image image image
image image image image image
image image image image image
image

Verification passed on Samsung Tab A with Android 10 running 1.25.65 x64 build

Verified test plan from brave/brave-core#8775
  • Verified grants is shown for JP locale
  • Verified able to claim grants
  • Verified wallet updates with UGP grant
  • Verified no mention of BAP Tokens or BAP on rewards panel/onboarding/rewards page/rewards internals page
  • Verified able to perform an one-time tip
  • Verified able to set a recurring tip
  • Verified able to perform a contribution
  • Verified no entry for Verify wallet on BR Panel
image image image image
image image image image
image image image image
image image image image

This was referenced May 27, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Remove Rewards JP-related restrictions for Android brave/brave-core
3 participants
@kjozwiak @zenparsing @srirambv