Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unretained call from key import #15961

Closed
spylogsster opened this issue May 19, 2021 · 1 comment · Fixed by brave/brave-core#8858
Closed

Remove Unretained call from key import #15961

spylogsster opened this issue May 19, 2021 · 1 comment · Fixed by brave/brave-core#8858

Comments

@spylogsster
Copy link

created from comment brave/brave-core#8777 (comment)

@stephendonner
Copy link

Verified PASSED using the testplan from brave/brave-core#8858 with build

Brave 1.26.43 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile, launched Brave
  2. opened brave://settings/ipfs
  3. loaded ipns://brantly.eth
  4. clicked on Use a local node
  5. downloaded http://mirror.sfo12.us.leaseweb.net/speedtest/10000mb.bin
  6. while downloading, closed the Settings tab
  7. waited for shared IPFS link to get copied to clipboard: https://dweb.link/ipfs/QmdBjHTfAp1v4DRBeraqSpXqDS4VvHa4RahTTUnZW3Kwsj?filename=10000mb.bin

Confirmed no crash while doing so; was able to open and save the 9.3 GB file from the above.

example example example
Screen Shot 2021-05-27 at 11 24 34 AM Screen Shot 2021-05-27 at 11 11 16 AM Screen Shot 2021-05-27 at 11 11 37 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants