Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show Refresh status for publishers on rewards panel #15966

Closed
srirambv opened this issue May 19, 2021 · 2 comments · Fixed by brave/brave-core#9118
Closed

Always show Refresh status for publishers on rewards panel #15966

srirambv opened this issue May 19, 2021 · 2 comments · Fixed by brave/brave-core#9118
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

As part of #15154, @Miyayes confirmed that Android should always shows Refresh Status button which is not available on Android. This is a follow up for #15154.

Steps to reproduce

  1. Clean install build
  2. Enable rewards and visit a verified pub page
  3. Click Refresh button to validate pub status
  4. Once pub is shown as Verified pub, refresh button is not shown again

Actual result

Refresh button is not shown once publisher status is updated

Expected result

Always show Refresh status for publishers on rewards panel

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Miyayes @deeppandya

@srirambv srirambv added feature/rewards QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels May 19, 2021
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 19, 2021
@deeppandya
Copy link

deeppandya commented Jun 3, 2021

Screenshot_20210603-173110 Screenshot_20210603-172941

@srirambv
Copy link
Contributor Author

srirambv commented Jun 24, 2021

Verification passed on OnePlus 6T with Android 10 running 1.27.77 x64 Beta build

  • Verified refresh status updates the publisher state and is retained
  • Verified refresh status is shown always for verified/connected/unverified publishers
Android.Tab.Refresh.Status.mp4

Verification passed on Samsung Tab A with Android 10 running 1.27.77 x64 Beta build

  • Verified refresh status updates the publisher state and is retained
  • Verified refresh status is shown always for verified/connected/unverified publishers
Android.ARM.Refresh.Status.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants