Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should IPFS submenu be all Title Case? #16040

Closed
stephendonner opened this issue May 22, 2021 · 1 comment · Fixed by brave/brave-core#8907
Closed

Should IPFS submenu be all Title Case? #16040

stephendonner opened this issue May 22, 2021 · 1 comment · Fixed by brave/brave-core#8907
Assignees
@spylogsster
Labels
feature/web3/ipfs OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.27.x - Release

Comments

@stephendonner
Copy link

Description

Should IPFS submenu be all Title Case?

Steps to Reproduce

  1. new profile
  2. load ipns://brantly.eth
  3. click on Use a local node
  4. load brave://settings/ipfs/keys
  5. click Add
  6. type newkey1 and click Generate
  7. click the "hamburger" menu and choose IPFS -> Share Local File Using IPFS
  8. now, expand the submenu and read it

Actual result:

Import and copy link to IPFS snapshot

Screen Shot 2021-05-22 at 12 53 32 AM

Expected result:

Should it be Import and Copy Link to IPFS Snapshot?

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.27.10 Chromium: 91.0.4472.70 (Official Build) nightly (x86_64)
Revision fe095368270a32c92959403754bf6fd357dd9953-refs/branch-heads/4472@{#1172}
OS macOS Version 11.5 (Build 20G5023d)

/cc @spylogsster @karenkliu
@spylogsster spylogsster self-assigned this May 22, 2021
@stephendonner stephendonner mentioned this issue May 22, 2021
Closed
@spylogsster spylogsster mentioned this issue May 23, 2021
Merged
24 tasks
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone May 24, 2021
@stephendonner
Copy link
Author

Verified FIXED using the inline testplan with build

Brave 1.27.25 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Confirmed the IPFS submenu item now reads Import and Copy Link to IPFS Snapshot.

Screen Shot 2021-05-27 at 4 23 20 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/ipfs OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

Move keys subitem to titlecase brave/brave-core
2 participants
@stephendonner @spylogsster