Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IPNS key doesn't dynamically appear in the key-management pane #16113

Closed
Tracked by #17112
stephendonner opened this issue May 27, 2021 · 1 comment · Fixed by brave/brave-core#8972
Closed
Tracked by #17112

Comments

@stephendonner
Copy link

Description

Added IPNS key doesn't dynamically appear in the key-management pane

Steps to Reproduce

  1. new profile, launch Brave
  2. load ipns://brantly.eth
  3. click on Use a local node
  4. wait until configuration is finished
  5. load brave://settings/ipfs/keys
  6. click on Add
  7. type a key name and click Import
  8. navigate to a key and choose Open
  9. wait
  10. look at brave://settings/ipfs/keys

Actual result:

The key you just added doesn't appear until you navigate away and back.

ipns-key-import

Expected result:

The newly-added key should dynamically appear in the Set up your IPNS keys Settings pane

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.26.43 Chromium: 91.0.4472.77 (Official Build) beta (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? n/a

/cc @spylogsster probably just need to attach an event listener?

@stephendonner
Copy link
Author

Verified FIXED using the inline testplan with build

Brave 1.27.33 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Confirmed that as soon as my mynewkey was imported, it showed up correctly in the Keys available for publishing list.

Screen Shot 2021-06-01 at 1 46 23 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment