Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird log formatting of conversion resource version #16303

Closed
btlechowski opened this issue Jun 9, 2021 · 1 comment · Fixed by brave/brave-core#9088
Closed

Weird log formatting of conversion resource version #16303

btlechowski opened this issue Jun 9, 2021 · 1 comment · Fixed by brave/brave-core#9088
Assignees
@tmancey
Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.27.x - Release

Comments

@btlechowski
Copy link

btlechowski commented Jun 9, 2021 •
edited
Loading

Follow up to #15491

Formatting of the version is weird. Check the screenshot

Steps to Reproduce

  1. Follow steps from VAC_URL from Add custom conversion ID patterns for Verifiable Advertiser Conversions brave-core#8640

Actual result:

Version formatting is weird
image
image

Expected result:

Version is 1

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.26.53 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS Ubuntu 18.04 LTS

cc @tmancey @moritzhaller @iambrianfung @jsecretan @brave/legacy_qa
@btlechowski btlechowski mentioned this issue Jun 10, 2021
Closed
@tmancey tmancey self-assigned this Jun 10, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. bug labels Jun 10, 2021
@tmancey tmancey mentioned this issue Jun 10, 2021
Merged
24 tasks
@tmancey tmancey added this to the 1.27.x - Nightly milestone Jun 11, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 6, 2021 •
edited
Loading

Verification passed on


Brave | 1.27.91 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
-- | --
Revision | 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS | Windows 10 OS Version 2004 (Build 19041.1052)
  • Verified the STR from the description and ensured Parsed verifiable conversion resource version 1 is shown in the logs
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.27.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes weird log formatting of conversion resource version brave/brave-core
3 participants
@tmancey @btlechowski @GeetaSarvadnya