conversionEnvelope is not attached to conversion's confirmation request

[btlechowski]

Follow up to #15491

The verifiable advertiser conversions don't work.

Steps to Reproduce

Test Case 1:

1. Follow steps from VAC_URL from Add custom conversion ID patterns for Verifiable Advertiser Conversions brave-core#8640
2. Check if the conversion confirmation contains conversionEnvelope

Test Case 2:

1. Follow steps from VAC_DOM from Add custom conversion ID patterns for Verifiable Advertiser Conversions brave-core#8640
2. Check if the conversion confirmation contains conversionEnvelope

Actual result:

conversionEnvelope is not attached to conversion's confirmation request

Expected result:

conversionEnvelope is attached to conversion's confirmation request
Example:

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Reproducible on

Brave	1.26.53 Chromium: 91.0.4472.77 (Official Build) beta (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Ubuntu 18.04 LTS

Not reproducible on

Brave	1.25.70 Chromium: 91.0.4472.77 (Official Build) (64-bit)
Revision	1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS	Linux

cc @tmancey @moritzhaller @iambrianfung @jsecretan @brave/legacy_qa

[iambrianfung]

@moritzhaller identified this to be that the logic does not accept dashes.
To resolve, we need to support [A-Z-z0-9\-]

[btlechowski]

QA/Blocked till #16918 lands in 1.27.x

[btlechowski]

VAC URL

Conversion was triggered:

[31727:31727:0715/114650.224627:VERBOSE1:conversions.cc(322)] Conversion for campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id 5e96fecc-2926-4c72-bb76-4e745bf6b539, creative instance id 7898a259-664a-4052-8382-9c7279ae3249 and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 on Thursday, July 15, 2021 at 11:46:50 AM
[31727:31727:0715/114650.242939:VERBOSE6:conversions.cc(375)] Successfully logged conversion event
[31727:31727:0715/114650.247042:VERBOSE3:conversions.cc(398)] Successfully appended conversion to queue
[31727:31727:0715/114650.258425:VERBOSE1:conversions.cc(503)] Convert campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id 5e96fecc-2926-4c72-bb76-4e745bf6b539, creative instance id 7898a259-664a-4052-8382-9c7279ae3249 and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 in 0 hours, 14 minutes, 50 seconds at 12:01 PM

The conversion id was extracted:

Verified conversion envelop was attached:

VAC DOM
Conversion was triggered:

[5449:5449:0715/123456.340893:VERBOSE1:conversions.cc(322)] Conversion for campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id 5e96fecc-2926-4c72-bb76-4e745bf6b539, creative instance id 7898a259-664a-4052-8382-9c7279ae3249 and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 on Thursday, July 15, 2021 at 12:34:56 PM
[5449:5449:0715/123456.362479:VERBOSE6:conversions.cc(375)] Successfully logged conversion event
[5449:5449:0715/123456.362532:VERBOSE3:conversions.cc(398)] Successfully appended conversion to queue
[5449:5449:0715/123456.386088:VERBOSE1:conversions.cc(503)] Convert campaign id 0d01425b-c970-4a25-b2d0-ccf748cfaf6e, creative set id 5e96fecc-2926-4c72-bb76-4e745bf6b539, creative instance id 7898a259-664a-4052-8382-9c7279ae3249 and advertiser id ecbcc833-8b1d-4867-98f7-ad2341396ce8 in 0 hours, 5 minutes, 18 seconds at 12:40 PM

The conversion id was extracted:

Verified conversion envelop was attached: