Unable to restart/update Brave via Relaunch button

[stephendonner]

Description

Steps to Reproduce

1. clean profile
2. launch Brave
3. go to Brave About Brave
4. click the Relaunch button

Actual result:

Nothing happens

Expected result:

Browser should restart/relaunch w/update

Reproduces how often:

100%

Brave version (brave://version info)

1.28.17 Chromium: 91.0.4472.114 (Official Build) nightly (x86_64)

[srirambv]

+1 on macOS Version 10.15.7

[kjozwiak]

Can't reproduce this on Win 10 x64. Seems like macOS specific. Nice find @stephendonner & @srirambv.

@rebron we should get this fixed sooner than later.

[rebron]

cc: @mihaiplesa

[mihaiplesa]

@stephendonner OS version?

[srirambv]

@mihaiplesa I see it on macOS Version 10.15.7

[mihaiplesa]

@srirambv I've seen you message above but would like to know if it happens on 11+

[simonhong]

I can repro this on my 11.3.1 macOS.

[mihaiplesa]

So the problem is not that the app updates and can't relaunch but that it presents the relaunch button and text when there is no update. I reproduced on 12 (Monterey beta).

[simonhong]

@mihaiplesa ah, 1.28.17 is our latest nightly?

[mihaiplesa]

Yes - on the public channels.

[NonstickAtom785]

Simple search says it's "fixed" already in the nightly builds. Is this not the case?

EDIT: Never mind. I read it more closely. I think the issue probably came from the "fix".

[mihaiplesa]

Trying to isolate the breaking change between 1.289 and 1.28.11.

@simonhong do you know if brave/brave-core#8642 could have had some unforeseen effects?

[mihaiplesa]

@brave/legacy_qa if the above PR is the cause then this would have manifested when updating from 1.26.64 to 1.24.65 on the test channels - anyone tried this?

[NonstickAtom785]

I don't think that commit had anything to do with the relaunch button. All I see is changes to the actual updater and installer.

[simonhong]

@mihaiplesa Well, I'm not sure.. I'm trying to test it on my local

[srirambv]

@mihaiplesa happens on 1.26.64 as well

Screen.Recording.2021-06-22.at.00.59.54.mov

[mihaiplesa]

@srirambv thanks for checking. 1.26.63 should be fine by my estimation.

[NonstickAtom785]

It definitely works in 1.25.45

[bsclifton]

Issue should be fixed by @mihaiplesa after revert:
master - brave/brave-core@14e74d6
1.27 - brave/brave-core@47f369b
1.26 - brave/brave-core@7f3c11a

We'll just need to get new binaries out 😄

[LaurenWags]

Verified passed with macOS x64 Catalina 10.15.7:

Brave | 1.26.67 Chromium: 91.0.4472.114 (Official Build) (x86_64)
-- | --
Revision | 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS | macOS Version 10.15.7 (Build 19H1030)

Reproduced the issue with 1.26.65, "Relaunch" button was shown on brave://settings/help when no update was present, clicking "Relaunch" did nothing.

Confirmed no "Relaunch" button was shown on brave://settings/help for 1.26.67 when no update was present.

1.26.65	1.26.67

Confirmed able to update from 1.25.73 --> 1.26.67 on test channel.
Confirmed able to update from 1.26.65 --> 1.26.67 on test channel.

---

Verified passed with macOS arm64 Big Sur 11.4:

Brave	1.26.67 Chromium: 91.0.4472.114 (Official Build) (arm64)
Revision	4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS	macOS Version 11.4 (Build 20F71)

Confirmed no "Relaunch" button was shown on brave://settings/help for 1.26.67 when no update was present:

Confirmed able to update from 1.25.73 --> 1.26.67 on test channel.

---

Verification passed on

Brave	1.26.67 Chromium: 91.0.4472.114 (Official Build) (x86_64)
Revision	4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS	macOS Version 10.15.7 (Build 19H114)

• Verified on clean install of 1.26.67 no relaunch button is shown in About Brave
• Verified upgrading from 1.25.73 to 1.26.67 doesn't show relaunch button in About brave
  

---

Verification PASSED on macOS 11.3 x64 using the following build:

Brave | 1.26.67 Chromium: 91.0.4472.114 (Official Build) (x86_64)
--- | ---
Revision | 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS | macOS Version 11.3 (Build 20E232)

• Confirmed able to update from 1.25.73 --> 1.26.67 on test channel.
• Confirmed able to update from 1.26.65 --> 1.26.67 on test channel.

Example	Example

[mherrmann]

Sorry everybody for the trouble and thank you for fixing this problem, which seems to have been caused by my PR. Thank you @mihaiplesa @bsclifton @simonhong 🙏