Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner Barely Visible in Dark Mode on Mac #16556

Closed
bitboss-ca opened this issue Jun 22, 2021 · 3 comments
Closed

Spinner Barely Visible in Dark Mode on Mac #16556

bitboss-ca opened this issue Jun 22, 2021 · 3 comments
Labels
closed/works-for-me design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop polish Nice to have — usually related to front-end/visual tasks

Comments

@bitboss-ca
Copy link

bitboss-ca commented Jun 22, 2021

Description

When loading pages in dark mode on a Mac, the spinner indicating loading progress is barely visible.

Steps to Reproduce

  1. Open Brave in dark mode on a mac
  2. Start loading a page

Actual result:

It's very difficult to see if there is any activity indicated by the round spinner on the page tab.

Screen Shot 2021-06-22 at 10 34 18 AM

Expected result:

View spinner to confirm that page is in the process of loading.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.25.73 Chromium: 91.0.4472.106 (Official Build) (x86_64)
Revision 574f7b38e4e7244c92c4675e902e8f8e3d299ea7-refs/branch-heads/4472@{#1477}
OS macOS Version 10.15.7 (Build 19H1217)
JavaScript V8 9.1.269.36
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.106 Safari/537.36
Command Line /Applications/Brave Browser.app/Contents/MacOS/Brave Browser --enable-dom-distiller --disable-domain-reliability --no-pings --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --enable-features=LegacyTLSEnforced,WebUIDarkMode,ReducedReferrerGranularity,PasswordImport,PrefetchPrivacyChanges,AutoupgradeMixedContent,SafetyTip --disable-features=AutofillServerCommunication,FledgeInterestGroups,FlocIdComputedEventLogging,HandwritingRecognitionWebPlatformApiFinch,HandwritingRecognitionWebPlatformApi,SubresourceWebBundles,NetworkTimeServiceQuerying,LangClientHintHeader,LiveCaption,InterestCohortFeaturePolicy,EnableProfilePickerOnStartup,TextFragmentAnchor,IdleDetection,DirectSockets,TrustTokens,SignedExchangeSubresourcePrefetch,NotificationTriggers,WebOTP,FederatedLearningOfCohorts,TabHoverCards,SharingQRCodeGenerator,FirstPartySets,InterestCohortAPIOriginTrial,FledgeInterestGroupAPI,AutofillEnableAccountWalletStorage,SignedExchangePrefetchCacheForNavigations --flag-switches-begin --enable-features=LegacyTLSEnforced,WebUIDarkMode,ReducedReferrerGranularity,PasswordImport,PrefetchPrivacyChanges,AutoupgradeMixedContent,SafetyTip,ReaderMode:discoverability/offer-in-settings --flag-switches-end
Executable Path /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
Profile Path /Users/[myusername]/Library/Application Support/BraveSoftware/Brave-Browser/Default
Variations 8eed39a1-b5b19078
1f0eeff1-46c97c06
aed3cac0-3f4a17df
7146a73c-3f4a17df
c63a3c82-3f4a17df
41ec777c-70ea8f25

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Unknown
  • Can you reproduce this issue with the nightly channel? Unknown

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Yes, but the spinner there is grey, so a little more visible.

Miscellaneous Information:

I am not colour blind.

@iam-cult
Copy link

This is intentional iirc, it then turns solid when the page loads

@bitboss-ca
Copy link
Author

Why would one want a spinner that is not visible? Wouldn't the user want to know if a page is loading or not?

@rebron rebron added polish Nice to have — usually related to front-end/visual tasks design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P5 Not scheduled. Don't anticipate work on this any time soon. closed/works-for-me and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels May 18, 2022
@rebron
Copy link
Collaborator

rebron commented May 18, 2022

Closing as works for me. Looks visible and mentioned wasn't due to the color. Possible that the page is loading too quickly.

Screen.Recording.2022-05-18.at.10.21.26.AM.mov

@rebron rebron closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/works-for-me design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Desktop polish Nice to have — usually related to front-end/visual tasks
Projects
None yet
Development

No branches or pull requests

3 participants