Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant import-video-to-IPFS context-menu items #16666

Closed
stephendonner opened this issue Jun 28, 2021 · 6 comments
Closed

Redundant import-video-to-IPFS context-menu items #16666

stephendonner opened this issue Jun 28, 2021 · 6 comments
Labels
closed/wontfix feature/web3/ipfs OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@stephendonner
Copy link

Description

Redundant import-video-to-IPFS context-menu items

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth
  4. click on Use a local node
  5. load https://en.wikipedia.org/wiki/File:Big_Buck_Bunny_4K.webm
  6. right-click the video file
  7. look at the resulting context-menu items

Actual result:

Two context-menu items appear:

  1. Selected Video > Import to IPFS
  2. Import to IPFS > Selected video

double-menu-items-ipfs

Expected result:

We should probably have only one of these context-menu items.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.34 Chromium: 91.0.4472.124 (Official Build) nightly (64-bit)
Revision 7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS Windows 10 OS Version 2009 (Build 21390.2025)
@spylogsster
Copy link

@stephendonner do you have IPFSCompanion installed as well?

@stephendonner
Copy link
Author

@stephendonner do you have IPFSCompanion installed as well?

Yes, I must have had it in my profile when testing go-ipfs 0.9.0 interop; sorry for forgetting to take stock and mention that!

@lidel
Copy link

lidel commented Jul 1, 2021

IPFS Companion could hide duplicate actions when running in Brave – mind filling issue in https://github.com/ipfs/ipfs-companion with list of actions to hide?

@stephendonner
Copy link
Author

IPFS Companion could hide duplicate actions when running in Brave – mind filling issue in https://github.com/ipfs/ipfs-companion with list of actions to hide?

Will try to get to this, but am heavily backlogged with other (more-pressing) work, so no promises 😄

@stephendonner
Copy link
Author

stephendonner commented Jul 8, 2021

@lidel @spylogsster it's all the context-menu import types (video, audio file, text, linked content, etc.), e.g. Import to IPFS -> This page (Brave side) & This page -> Import to IPFS (Companion side).

At least they're differently worded, so we can tell them apart, for now 😄

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label May 18, 2022
@vadimstruts
Copy link
Collaborator

The IPFS local node and scheme has been deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix feature/web3/ipfs OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

5 participants