Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotated keys don't appear until you manually reload the Settings page #16743

Closed
stephendonner opened this issue Jul 1, 2021 · 1 comment · Fixed by brave/brave-core#9342
Closed

Comments

@stephendonner
Copy link

Description

Rotated keys don't appear until you manually reload the Settings page

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load ipns://brantly.eth and click Use a local node
  4. go to brave://settings/ipfs/keys and click on the reload icon next to the self key
  5. type rotatedKey and click Rotate

Actual result:

Nothing visible happens

Screen Shot 2021-07-01 at 2 05 46 PM

Expected result:

Now, click the browser's Reload button, and rotatedKey appears

Screen Shot 2021-07-01 at 2 11 45 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.28.46 Chromium: 92.0.4515.70 (Official Build) nightly (x86_64)
Revision 2df01a82398e62190b2aae01aaad7ca3d47aba01-refs/branch-heads/4515@{#923}
OS macOS Version 11.4 (Build 20F71)
@stephendonner
Copy link
Author

Verified FIXED using the inline testplan with build

Brave 1.28.64 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launched Brave
  3. loaded ipns://brantly.eth and clicked Use a local node
  4. in a new tab, went to brave://settings/ipfs/keys and click on the reload icon next to the self key
  5. typed rotatedKey and clicked Rotate

Confirmed the Settings pane refreshed, and both self and newly rotated rotatedKey were shown.

ipfs-keys-rotate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants