Remove "Brave" in "Show Brave suggested sites in autocomplete suggestions" description

[stephendonner]

Description

Remove "Brave" in "Show Brave suggested sites in autocomplete suggestions" description

Steps to Reproduce

1. new profile
2. launch Brave
3. load brave://settings/appearance
4. look at Show Brave suggested sites in autocomplete suggestions

Actual result:

Says Show Brave suggested sites in autocomplete suggestions

Expected result:

Should just be Show suggested sites in autocomplete suggestions, per discussion with @rmcfadden3 @karenkliu, as they're not actually our suggestions

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision	dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS	macOS Version 11.4 (Build 20F71)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

[srirambv]

This was done for the Brave referral links suggestions. Not sure if we need to have the setting itself anymore.

cc: @bbondy

[bbondy]

Brendan had mentioned some people liked to have it to support Brave and to leave it for now, so we'll just leave it for now. We can definitely do the text change though.

[Tonev]

@stephendonner @bbondy

If you have decided this needs a change, I can do the change over here:
https://github.com/brave/brave-core/blob/73096ec8b947b31cac0bc8499bc4b39c1847fa6b/app/brave_generated_resources.grd#L349

I believe that's all that has to be changed.

[stephendonner]

@stephendonner @bbondy

If you have decided this needs a change, I can do the change over here: https://github.com/brave/brave-core/blob/73096ec8b947b31cac0bc8499bc4b39c1847fa6b/app/brave_generated_resources.grd#L349

I believe that's all that has to be changed.

Sure, I don't see any change in direction, so removing Brave from that text seems good to me 👍 Put it up for review and tag the usual suspects.

[Tonev]

@stephendonner

Feel free to assign the issue to me, I have an open pull request that should fix it 👍

[Tonev]

@stephendonner, could you please use your rights to request a review for the PR? It's a one-word-change, but unfortunately it's taking a few days for a review 🤔

[bsclifton]

@Tonev just assigned @mkarolin for review; some of the localizations can be tricky, because they get auto-generated. I suspect it may need to be changed another place. For example, we'll auto-replace a set of words on Chromium upgrade and do a replace of Google with Brave

[bbondy]

Sorry for any lost time but let's close this. The feature is related to Brave's list, which is not really maintained anymore. But it is Brave specific.

[bbondy]

Actually I see the PR is already there and approved and correct, so I'll take that back and re-open.

[stephendonner]

Verified PASSED using

Brave	1.39.39 Chromium: 100.0.4896.79 (Official Build) nightly (x86_64)
Revision	8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS	macOS Version 11.6.5 (Build 20G527)

Confirmed Brave has been removed, and the text now reads Show suggested sites in autocomplete suggestions.

[MadhaviSeelam]

Brave	1.39.83 Chromium: 101.0.4951.41 (Official Build) beta (64-bit)
Revision	93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS	Windows 11 Version 21H2 (Build 22000.613)

Confirmed Brave has been removed, and the text now reads Show suggested sites in autocomplete suggestions.