Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave private ads should read Brave Private Ads in brave://settings/shields #16987

Closed
stephendonner opened this issue Jul 16, 2021 · 2 comments · Fixed by brave/brave-core#9463

Comments

@stephendonner
Copy link

Description

Brave private ads should read Brave Private Ads in brave://settings/shields.

Steps to Reproduce

  1. new profile
  2. launch Brave
  3. load brave://settings/shields
  4. read the 2nd paragraph under Block trackers and ads which follow you across the web.

Actual result:

Reads Brave private ads.

Screen Shot 2021-07-15 at 9 50 16 PM

Expected result:

Should read Brave Private Ads.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.29.3 Chromium: 92.0.4515.101 (Official Build) nightly (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 12.0 (Build 21A5268h)

/cc @rmcfadden3 @karenkliu

@stephendonner stephendonner added good first issue needs-text-change This change requires some careful wording. OS/Desktop labels Jul 16, 2021
@deepxcode
Copy link

I would like to work on this issue. Can you assign this to me?

@stephendonner
Copy link
Author

Verified FIXED using

Brave 1.29.12 Chromium: 92.0.4515.101 (Official Build) nightly (x86_64)
Revision edb73f4fb624e2ea0cb6f5cc39c9e317ecd3535b-refs/branch-heads/4515@{#1536}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. launch Brave
  3. load brave://settings/shields
  4. read the 2nd paragraph under Block trackers and ads which follow you across the web.

Confirmed it reads Brave Private Ads now.

Screen Shot 2021-07-20 at 9 44 55 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants