Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pref for disabling stats ping #17158

Closed
4 tasks
srirambv opened this issue Jul 26, 2021 · 7 comments · Fixed by brave/brave-core#9666
Closed
4 tasks

Create pref for disabling stats ping #17158

srirambv opened this issue Jul 26, 2021 · 7 comments · Fixed by brave/brave-core#9666
Assignees
@samartnik
Labels
network/startup requests OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.30.x - Release

Comments

@srirambv
Copy link
Contributor

@keur Android specific issue for feature implementation as #16583 is desktop

Description

  • Create a preference for disabling the stats ping

Designs

  • Add usage ping toggle
  • Update text for P3A and Automatic crash reporting settings
  • Move crash reporting, usage ping, and P3A toggles to be closer to each other

Assets

TBA

cc: @karenkliu for Assets and Design, @SergeyZhukovsky @anthonypkeane to prioritize
@srirambv srirambv added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality network/startup requests labels Jul 26, 2021
@srirambv srirambv mentioned this issue Jul 26, 2021
Closed
4 tasks
@diracdeltas
Copy link
Member

does this also need to be done on iOS?

@bsclifton
Copy link
Member

@diracdeltas yes - I believe so. cc: @anthonypkeane

@anthonypkeane anthonypkeane mentioned this issue Jul 29, 2021
Closed
4 tasks
@samartnik samartnik self-assigned this Aug 4, 2021
@samartnik samartnik mentioned this issue Aug 5, 2021
Merged
24 tasks
@samartnik
Copy link
Contributor

device-2021-08-05-103358

@samartnik
Copy link
Contributor

@keur do you know how QA may test it on Android? I was able to check it only using temporary logs.

@kkuehlz
Copy link
Contributor

kkuehlz commented Aug 5, 2021

@samartnik Is it possible for them to setup wireshark or any other network analyzers on an Android or the emulator? That's how we check it on desktop

@srirambv
Copy link
Contributor Author

srirambv commented Aug 6, 2021

@keur can use Charles Proxy for this checking stats ping.

@samartnik samartnik added this to the 1.30.x - Nightly milestone Aug 6, 2021
@srirambv
Copy link
Contributor Author

Verification passed on Oppo Reno 5 with Android 11 running 1.30.82 x64 build

  • Verified no usage ping is sent when the setting is disabled
  • Verified enabling the setting and restarting the browser sends usage ping
First launch ping (setting enabled by default) Disable setting after moving date by 1 day Enable Setting and restart browser Android setting
img img img image

@kjozwiak kjozwiak mentioned this issue Oct 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
network/startup requests OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Added toggle for Brave stats brave/brave-core
5 participants
@diracdeltas @bsclifton @srirambv @kkuehlz @samartnik