Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Start video call" button should be "Start call" on Brave Talk widget #17250

Closed
stephendonner opened this issue Jul 30, 2021 · 15 comments · Fixed by brave/brave-core#10703
Closed

Comments

@stephendonner
Copy link

stephendonner commented Jul 30, 2021

Description

Start video call button should be Start call on Brave Talk widget

Steps to Reproduce

  1. new nightly profile
  2. launch Brave
  3. open a new-tab page
  4. click on Customize on the lower right
  5. click on Cards
  6. click on the + Add button for Brave Talk
  7. close the dialog by clicking on the X
  8. under Brave Talk, look at the button text

Actual result:

Left: talk.brave.software and, Right: Brave Talk new-tab widget

Start call and Start video call

Screen Shot 2021-07-29 at 4 15 27 PM

Expected result:

Button text should read Start call.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.29.39 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS macOS Version 11.5.1 (Build 20G80)

Note also: this will require its card image asset to be updated again, if we choose to do so:
Screen Shot 2021-07-29 at 4 50 58 PM

@Zulkarnine1
Copy link

Hi, I would like to start working on this issue.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Aug 6, 2021
@ishan1880
Copy link

Is this issue still available? I would like to work on this.

@Muneeb2017
Copy link

Is this available? Can you assign it to me

@stephendonner
Copy link
Author

@Zulkarnine1 apologies for the protracted delay responding; are you still up for taking and fixing this?

@Zulkarnine1
Copy link

I'm sorry, but I don't think I'll be available. I hope someone else can fix it.

@bmxtricky
Copy link

Hi @stephendonner id like to take on the issue if no one else is on it

@optimm
Copy link

optimm commented Sep 19, 2021

Hi @stephendonner i am new to open source ans would like to work on this issue , if you could please guide me it would be helpfull

@stephendonner
Copy link
Author

Is this issue still available? I would like to work on this.

It is now; are you still available? Thanks!

@Goldmine96
Copy link

Hi
Does this only involve changing the text displayed on the button from
"Start video call" to "start call"?

@stephendonner
Copy link
Author

Hi
Does this only involve changing the text displayed on the button from
"Start video call" to "start call"?

In addition to that change, we also need the new image asset for the Brave Talk card updated and uploaded, along with that string change.

@ProttoyChakraborty
Copy link

Hi, I would like to work on this issue, just reconfirming the tasks to be completed

  1. change the button text from "Start video Call" --> "Start Call"
  2. Update and Upload the new card image asset reflected in the customize dashboard menu.

@pranavramesh123
Copy link

Hi, I would like to work on this issue. Is this issue still available?

1 similar comment
@ApurvR20
Copy link

ApurvR20 commented Oct 6, 2021

Hi, I would like to work on this issue. Is this issue still available?

@stephendonner
Copy link
Author

@nullhook mind just taking care of this long-in-the-tooth issue, please? Then we can point contributors to another, uncluttered issue(s) to work on :-)

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.33.46 Chromium: 95.0.4638.69 (Official Build) nightly (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.6.1 (Build 20G224)

Steps:

  1. new nightly profile
  2. launch Brave
  3. open a new-tab page
  4. click on Customize on the lower right
  5. click on Cards
  6. click on the + Add button for Brave Talk
  7. close the dialog by clicking on the X
  8. under Brave Talk, look at the button text

Confirmed both button and screen grab of button in Cards both say Start call:

example example
Screen Shot 2021-10-29 at 1 09 09 PM Screen Shot 2021-10-29 at 1 09 16 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment