-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Start video call" button should be "Start call" on Brave Talk widget #17250
Comments
Hi, I would like to start working on this issue. |
Is this issue still available? I would like to work on this. |
Is this available? Can you assign it to me |
@Zulkarnine1 apologies for the protracted delay responding; are you still up for taking and fixing this? |
I'm sorry, but I don't think I'll be available. I hope someone else can fix it. |
Hi @stephendonner id like to take on the issue if no one else is on it |
Hi @stephendonner i am new to open source ans would like to work on this issue , if you could please guide me it would be helpfull |
It is now; are you still available? Thanks! |
Hi |
In addition to that change, we also need the new image asset for the Brave Talk card updated and uploaded, along with that string change. |
Hi, I would like to work on this issue, just reconfirming the tasks to be completed
|
Hi, I would like to work on this issue. Is this issue still available? |
1 similar comment
Hi, I would like to work on this issue. Is this issue still available? |
@nullhook mind just taking care of this long-in-the-tooth issue, please? Then we can point contributors to another, uncluttered issue(s) to work on :-) |
Verified
Steps:
Confirmed both button and screen grab of button in Cards both say
|
Description
Start video call
button should beStart call
on Brave Talk widgetSteps to Reproduce
nightly
profileCustomize
on the lower rightCards
+ Add
button for Brave TalkX
Brave Talk
, look at the button textActual result:
Left:
talk.brave.software
and, Right: Brave Talk new-tab widgetStart call
andStart video call
Expected result:
Button text should read
Start call
.Reproduces how often:
100%
Brave version (brave://version info)
Note also: this will require its card image asset to be updated again, if we choose to do so:
The text was updated successfully, but these errors were encountered: