Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dapp detection infobar, lazy loading setting & infobar, and more #17762

Closed
bbondy opened this issue Aug 30, 2021 · 3 comments
Closed

Remove Dapp detection infobar, lazy loading setting & infobar, and more #17762

bbondy opened this issue Aug 30, 2021 · 3 comments
Assignees
@bbondy
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.32.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Aug 30, 2021 •
edited
Loading

  • Dapp detection is no longer needed, remove the infobar
  • Remove the setting for always loading Crypto Wallets on startup
  • Always actively load the Crypto Wallets extension so long as it is set as the Dapp provider
  • Otherwise lazily load Crytpo Wallets the first time the user visits brave://wallet when the native wallet flag is off
@bbondy bbondy mentioned this issue Aug 30, 2021
Closed
@bbondy bbondy changed the title Remove Dapp detection for when the new wallet is in use Remove Dapp detection Sep 10, 2021
@bbondy
Copy link
Member Author

bbondy commented Sep 10, 2021

cc @jamesmudgett

@bbondy bbondy changed the title Remove Dapp detection Remove Dapp detection, lazy loading setting and more Sep 10, 2021
@bbondy bbondy changed the title Remove Dapp detection, lazy loading setting and more Remove Dapp detection, lazy loading setting, infobar and more Sep 10, 2021
@bbondy bbondy changed the title Remove Dapp detection, lazy loading setting, infobar and more Remove Dapp detection infobar, lazy loading setting & infobar, and more Sep 10, 2021
@bbondy bbondy self-assigned this Sep 10, 2021
@bbondy
Copy link
Member Author

bbondy commented Sep 22, 2021

Closing as a dupe of the better spec'ed out issue #18213

@bbondy bbondy closed this as completed Sep 22, 2021
@bbondy bbondy added this to the 1.32.x - Nightly milestone Sep 24, 2021
@stephendonner stephendonner added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 27, 2021
@srirambv
Copy link
Contributor

Brave 1.32.81 Chromium: 95.0.4638.54 (Official Build) beta (64-bit)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.194) 		☑️ macOS Version 11.5.2
(Build 20G95)
  • Verified Dapp detection doesn't show any info bar
  • Verified there is no setting for always loading Crypto Wallets on startup
  • Verified Crytpo Wallets extension loads when it is set as default Dapp provider
  • Verified Crytpo Wallets extension is lazy loaded when native wallet flag is off or set as default Dapp provider
Additional verification notes can be found here

@kjozwiak kjozwiak mentioned this issue Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.32.x - Release
Development

No branches or pull requests
4 participants
@stephendonner @bbondy @kjozwiak @srirambv