-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pending tips for Gemini creators not sent when switching from Uphold to Gemini #17766
Comments
Verified using
Clean Profile - PASSEDPer brave/brave-core#10324 (comment), confirmed database migration (v1 -> v33) is successful.
Upgrade Profile - PASSEDInstalled 1.31.87 and enabled Rewards.
Upgraded to 1.32.81 by renaming the profile.
Uphold --> Gemini wallet change - PASSEDVerified test plan from brave/brave-core#10324 (comment) Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:
Confirmed able to disconnect from Uphold and connect Gemini account per step 4: Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel: I checked the logs and saw that the tip was now being initiated. Step 6 logs
Confirmed the tip and fee were sent successfully
Gemini --> Uphold wallet change - PASSEDVerified test plan from brave/brave-core#10324 (comment) Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:
Confirmed able to disconnect from Uphold and connect Gemini account per step 4: Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel: I checked the logs and saw that the tip was now being initiated. Step 6 logs
Confirmed the tip and fee were sent successfully
Verification passed on
Verified test plan from brave/brave-core#10324
Verified wallet with uphold
![image](https://user-images.githubusercontent.com/34715963/141194774-d9f566eb-8abb-46cd-b263-9f07a5a468c8.png)
Made the tip to gemini verified creator lands in pending contributions Verified after 3 days the tip was removed from pending contributions Verified database was migrated Verified there's no |
Verified
Clean Profile - PASSEDPer brave/brave-core#10324 (comment), confirmed database migration (v1 -> v33) is successful.
Upgrade Profile - PASSEDInstalled 1.31.87 and enabled Rewards.
Upgraded to 1.32.81 by renaming the profile.
Uphold --> Gemini wallet change - PASSEDVerified test plan from brave/brave-core#10324 (comment) Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:
Confirmed able to disconnect from Uphold and connect Gemini account per step 4: Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel: I checked the logs and saw that the tip was now being initiated. Step 6 logs
Confirmed the tip and fee were sent successfully
Gemini --> Uphold wallet change - PASSEDVerified test plan from brave/brave-core#10324 (comment) Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:
Confirmed able to disconnect from Gemini and connect Uphold account per step 4: Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel: I checked the logs and saw that the tip was now being initiated. Step 6 logs
Confirmed the tip and fee were sent successfully
|
Verified Clean Profile - PASSEDPer brave/brave-core#10324 (comment), confirmed database migration (v1 -> v33) is successful.
Upgrade Profile - PASSEDInstalled 1.31.87 and enabled Rewards.
Upgraded to 1.32.81 by renaming the profile.
Uphold --> Gemini wallet change - PASSEDVerified test plan from brave/brave-core#10324 (comment) Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:
Confirmed able to disconnect from Uphold and connect Gemini account per step 4: Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel: I checked the logs and saw that the tip was now being initiated. Step 6 logs
Confirmed the tip and fee were sent successfully
Gemini --> Uphold wallet change - PASSEDVerified test plan from brave/brave-core#10324 (comment) Confirmed when tipping a Gemini verified creator from an Uphold User wallet (step 3), the tip is sent to pending list:
Confirmed able to disconnect from Gemini and connect Uphold account per step 4: SCREENSHOT Advanced computer clock by 3 days as per step 5. On relaunch, I got this message from the panel: SCREENSHOT I checked the logs and saw that the tip was now being initiated. Step 6 logs
Confirmed the tip and fee were sent successfully
|
Description
If a user changes their custodial wallet from Uphold to Gemini, pending tips that were earmarked for a Gemini creator are not being sent out once the change to Gemini is made.
Steps to Reproduce
Actual result:
Pending tip is not sent to the Gemini creator, it remains in the pending list. I tried the following per suggestions to get this to happen:
Expected result:
At some point the pending tip for Gemini creator should be sent out
Reproduces how often:
easily
Brave version (brave://version info)
1.29.75
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @brave/legacy_qa @Miyayes @jumde @rebron
The text was updated successfully, but these errors were encountered: