Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profile icon too large #1856

Closed
rossmoody opened this issue Oct 26, 2018 · 4 comments
Closed

Profile icon too large #1856

rossmoody opened this issue Oct 26, 2018 · 4 comments
Assignees
@rossmoody
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.57.x - Release ...

Comments

@rossmoody
Copy link
Contributor

rossmoody commented Oct 26, 2018 •
edited by petemill
Loading

The profile icon is 2px too large and it's causing the menu icon stroke to look to skinny in immediate relation to it.

image

Test plan

Avatar icon still shows, just slightly smaller
@rossmoody rossmoody self-assigned this Oct 26, 2018
@rossmoody rossmoody mentioned this issue Oct 26, 2018
Merged
@srirambv srirambv added feature/user-interface All UI related design A design change, especially one which needs input from the design team labels Oct 27, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Oct 27, 2018
@rebron rebron modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Nov 2, 2018
@rebron
Copy link
Collaborator

rebron commented Nov 2, 2018

marking wontfix, we're going to change this completely.

@rebron rebron closed this as completed Nov 2, 2018
@rossmoody
Copy link
Contributor Author

@rebron I have a pr with a fix for this ready to merge. Even if this changes it’ll help in the interim

@rossmoody rossmoody reopened this Nov 2, 2018
@rossmoody
Copy link
Contributor Author

It’s just 10 lines of skia code that need approved and merged

@bbondy bbondy modified the milestones: Dupe / Invalid / Not actionable, 1.x Backlog Nov 5, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 0.57.x - Beta Nov 28, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Nov 29, 2018 •
edited by btlechowski
Loading

Verified passed with

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X

Top is 0.57.8 Beta, bottom is 0.56.15 Release
screen shot 2018-11-29 at 10 26 26 am

Verified PASSED on Ubuntu 17.10

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Linux

image

Verified PASSED on

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Windows 7

image

@kjozwiak kjozwiak mentioned this issue Dec 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rossmoody rossmoody

Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

No branches or pull requests
7 participants
@petemill @bbondy @rebron @srirambv @LaurenWags @rossmoody @btlechowski