Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document.referer leaks the referrer #1861

Closed
jumde opened this issue Oct 26, 2018 · 3 comments · Fixed by brave/brave-core#754
Closed

document.referer leaks the referrer #1861

jumde opened this issue Oct 26, 2018 · 3 comments · Fixed by brave/brave-core#754
Assignees
@yrliou
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA/No release-notes/exclude
Milestone
0.56.x - Release ...

Comments

@jumde
Copy link
Contributor

jumde commented Oct 26, 2018

Referer headers are spoofed in brave, but document.referer leaks the current referer
@jumde jumde added privacy priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 26, 2018
@bbondy
Copy link
Member

bbondy commented Oct 28, 2018

This was a regression and we have a test fail for it, @yrliou will fix on Monday.

@bbondy bbondy added this to the 0.56.x - Beta milestone Oct 28, 2018
@yrliou yrliou mentioned this issue Oct 28, 2018
Merged
18 tasks
@yrliou yrliou added the QA/No label Oct 28, 2018
@yrliou
Copy link
Member

yrliou commented Oct 28, 2018

Marked as QA/No because it is covered by browser tests.

@bbondy
Copy link
Member

bbondy commented Oct 28, 2018

@yrliou will fix on Monday.

I lied, she did it today :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA/No release-notes/exclude
Projects
None yet
Milestone
0.56.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Allow redirecting to the same URL when referrer is overwritten brave/brave-core
4 participants
@bbondy @jumde @kjozwiak @yrliou