Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page background paints as white before image loads on New Tab Page. #1876

Closed
bradleyrichter opened this issue Oct 28, 2018 · 4 comments · Fixed by brave/brave-core#1091
Closed
Assignees
Labels
polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@bradleyrichter
Copy link

Description

Page background paints as white before image loads on New Tab Page. This is most apparent when using Mac OS Mohave in Dark Mode.

Steps to Reproduce

  1. Set Dark Mode on Mac OS Mohave
  2. Set Brave Colors to Dark
  3. Make new tabs and notice the page background paint in as white before BG image loads

Actual result:

seemingly unnecessary white flash of the entire page area.

Expected result:

"Black Flash" or none by preloading the image or or a different approach to eliminate the visible page background draw.

Reproduces how often:

every time

Brave version (brave://version info)

Version 0.55.20 Chromium: 70.0.3538.67 (Official Build) (64-bit)

@bradleyrichter bradleyrichter added polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Oct 28, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 28, 2018
@jpuris
Copy link

jpuris commented Nov 14, 2018

This is extremely annoying behaviour.
Any workaround until it is fixed would be much appreciated!

Can be reproduced on Version 0.57.4 (Dev)

Edit: Can the new tab dashboard be disabled or replaced ? That would work for me as temp fix.

@LaurenWags
Copy link
Member

I don't have Mojave on macOS, but it's still happening for me with Brave using dark colors. You can kind of see it in this gif:
1876

@kjozwiak can you check your macOS with mojave when you get a chance?

@LaurenWags
Copy link
Member

LaurenWags commented Feb 14, 2019

Verified with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification passed on

Brave 0.60.29 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Linux

Verification passed on

Brave 0.60.29 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Reproduced #3362

@kjozwiak
Copy link
Member

Checked this with @LaurenWags while we were on a call together as I'm running Mojave. Still seeing the "white flash" when opening new tabs. Also seeing a "white flash" whenever switching between brave://newtab tabs. Example of the issue:

switchingtabs

Used the following build:

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

@rossmoody @bradleyrichter seems like this is still an issue as per the above example. I don't think we're going to fix this in time for 0.60.x so @LaurenWags opened #3362 as a follow up as there's code that already landed in this issue so we're not going to re-open unless we try fixing this in this issue by Monday-Tuesday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants