Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux - Ubuntu (Fedora): Dev/Beta Builds opens in new dock location, displays wrong icon in dock #1888

Closed
Brave-Matt opened this issue Oct 29, 2018 · 4 comments
Labels
misc/icons OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@Brave-Matt
Copy link

Description

@mbacchi Has Fedora information, will add to this issue later.

In Ubuntu (18.04), the Developer and Beta Build shows up in a new icon on the doc as opposed to adding new windows to the same dock icon (see third gif opening Firefox to compare). Additionally, when launching the Developer build, I'm seeing the Stable build icon displayed in the doc rather than the developer build. Screens of the behavior:

Original video report from Reddit user:

The bug in Brave Dev for Linux (Probably not specifically Ubuntu) from r/brave_browser

My testing of the issue (includes incorrect icon displaying:
devubuntu

Compared to launching Firefox:
devubuntu2

#Steps to Reproduce

  1. Download/install fresh Ubuntu profile of Dev/Beta
  2. Launch Dev/Beta
  3. Open additional window(s)

Actual result:

Brave (Dev/Beta) launches and displays in a second icon in the dock. Launching additional windows appear in the second docked icon.

Expected result:

Brave windows are displayed/appear in the original docked icon.

Reproduces how often:

Easily

Brave version (brave://version info)

Dev - v0.57.3
Beta - v0.56.6

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    No.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional Information

Link to original report: https://www.reddit.com/r/brave_browser/comments/9sdpod/the_bug_in_brave_dev_for_linux_probably_not/

@bsclifton bsclifton added this to the 1.x Backlog milestone Oct 29, 2018
@kpuljek
Copy link

kpuljek commented Oct 31, 2018

This happens because Brave doesn't have a proper StartupWMClass set in its .desktop file. I had to add it manually on more than one installation:
StartupWMClass=brave-browser

GNOME and other modern desktops just don't know that the newly spawned process matches the icon on the dock and just makes a new one.

I'd also like to point out that in situations where I had multiple versions installed (stable, beta and/or dev), this problem appeared much more often and the above WM class solution worked sporadically. Probably because brave beta also has WM Class: WM_CLASS(STRING) = "brave-browser", "Brave-browser" so GNOME doesn't know which one it is.

@mbacchi mbacchi added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 31, 2018
@srirambv
Copy link
Contributor

Possible duplicate of #1746 & #1032

@fmarier
Copy link
Member

fmarier commented Sep 27, 2019

I cannot reproduce this. I suspect it may have been fixed as a result of fixing #1324.

@Brave-Matt are you still seeing this problem?

@fmarier
Copy link
Member

fmarier commented Feb 29, 2020

I'll assume this is resolved for dev/beta. We have another issue open for Nightly: #1746

@fmarier fmarier closed this as completed Feb 29, 2020
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc/icons OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

8 participants