Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allow-forever option in per-origin noscript settings #1889

Open
bsclifton opened this issue Oct 29, 2018 · 4 comments
Open

Support allow-forever option in per-origin noscript settings #1889

bsclifton opened this issue Oct 29, 2018 · 4 comments
Assignees
Labels
feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon".

Comments

@bsclifton
Copy link
Member

bsclifton commented Oct 29, 2018

Carried over from brave/browser-laptop#9307 (this functionality was missing from browser-laptop/Muon) and requested by @Jacalz:

It would be great to have an option to allow certain scripts forever or to always have the browser to remember wich scripts I want blocked on a specific site. And having the option in here:
screenshot_1
Originaly posted from community: https://community.brave.com/t/allow-scripts-dropdown-in-address-bar-should-have-an-allow-forever-option/3141
but I would also love this 👍

The UI for shields looks a little different now (per redesign by @karenkliu and team)
cc: @tomlowenthal for triage

@bsclifton bsclifton added feature/shields The overall Shields feature in Brave. feature/shields/!scripts Blocking JavaScript with Shields labels Oct 29, 2018
@bsclifton bsclifton added this to the 1.x Backlog milestone Oct 29, 2018
@tildelowengrimm tildelowengrimm added priority/P4 Planned work. We expect to get to it "soon". and removed browser-laptop-parity labels Oct 31, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@DaveA-W
Copy link

DaveA-W commented Mar 23, 2019

+1

1 similar comment
@davidhfo
Copy link

davidhfo commented May 7, 2019

+1

@Brave-Matt
Copy link

+1 community:
https://community.brave.com/t/no-more-saving-shield-preferences-per-site-re-open-nov-2018-posting/69622/3

@bsclifton
Copy link
Member Author

+1 from @snives via #5705

Description

Using Brave Shields, enabling script blocking, and then selecting the mix of scripts I wish to allow, does not permanently remember this selection for this website. In effect, the site is broken without enabling a certain set of scripts, thus because brave only remembers these settings "one time", the site will always be broken (unless I disable all script blocking of course, which is not what I want).

Expectation

My expectation and desire is that it DOES remember these settings permanently for this website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/!scripts Blocking JavaScript with Shields feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

7 participants