Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable horizontal scroll on read-only detailed views #1892

Closed
tildelowengrimm opened this issue Oct 29, 2018 · 8 comments · Fixed by brave/brave-core#1797
Closed

Enable horizontal scroll on read-only detailed views #1892

tildelowengrimm opened this issue Oct 29, 2018 · 8 comments · Fixed by brave/brave-core#1797
Assignees
@cezaraugusto
Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
0.64.x - Release ...

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Oct 29, 2018 •
edited by karenkliu
Loading

Description

When looking at the detailed view of 3rd-party trackers blocked, Connections upgraded to HTTPS, and device recognition blocked, we should enable horizontal scrolling so that someone can see the full element URL.

Designs

3rd-party trackers detail view:
3rd-party trackers breakdown

Connections upgraded to HTTPS detail view:
https upgrades breakdown

Device recognition detail view:
shields device recognition breakdown

For more CSS and plain text, check Abstract link: https://share.goabstract.com/68d70c4d-8c77-4588-9ee5-ce6418505c79
@tildelowengrimm tildelowengrimm added the feature/shields The overall Shields feature in Brave. label Oct 29, 2018
@tildelowengrimm tildelowengrimm added this to the 1.0 milestone Oct 29, 2018
@bbondy bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018
@tildelowengrimm tildelowengrimm added design A design change, especially one which needs input from the design team priority/P5 Not scheduled. Don't anticipate work on this any time soon. feature/shields/panel Front-end design and functionality of the Shields panel. labels Oct 31, 2018
@tildelowengrimm
Copy link
Contributor Author

The designs for this should be part of #1934.

@tildelowengrimm tildelowengrimm added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 28, 2018
@karenkliu
Copy link

Closing this issue because comprehensive design specs and other issues are covered by #2565

@bbondy bbondy modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Dec 20, 2018
@karenkliu karenkliu reopened this Jan 24, 2019
@karenkliu
Copy link

Reopening this issue because #2565 has been split into smaller issues.

@karenkliu karenkliu changed the title Enable horizontal scroll on detailed views Enable horizontal scroll on read-only detailed views Jan 24, 2019
@karenkliu karenkliu assigned cezaraugusto and unassigned karenkliu Jan 24, 2019
@karenkliu
Copy link

This passed design QA 👍

@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2019

Reopening this issue because #2565 has been split into smaller issues.

Removing Dupe / Invalid / Not actionable milestone as per the above.

@kjozwiak kjozwiak removed this from the Dupe / Invalid / Not actionable milestone Feb 6, 2019
@cezaraugusto cezaraugusto mentioned this issue Feb 20, 2019
Merged
9 tasks
@karenkliu
Copy link

Hi @cezaraugusto, I took a look at your latest updates at https://brave-ui-959w0ii2u.now.sh. The scroll seems to work correctly, but there's a minor visual design issue where the scroll area seems to leave a gap at the top + bottom. Please fix these issues:

enable scroll design qa

@karenkliu
Copy link

Hi @cezaraugusto, your latest build to enable scroll looks good to go from the design side. 👍

@cezaraugusto cezaraugusto mentioned this issue Mar 8, 2019
Merged
4 tasks
@cezaraugusto cezaraugusto added this to the 0.64.x - Nightly milestone Mar 13, 2019
@btlechowski
Copy link

btlechowski commented Apr 25, 2019 •
edited by srirambv
Loading

Verification passed on

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#1797
Horizonal scrollbars are enabled
image

Logged #4227

Verified passed with

Brave 0.64.62 Chromium: 74.0.3729.108 (Official Build) beta(64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Mac OS X

Screen Shot 2019-04-26 at 5 22 30 PM

Verification passed on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Screenshot from 2019-05-07 10-14-31

@kjozwiak kjozwiak mentioned this issue May 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
design A design change, especially one which needs input from the design team feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
0.64.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

several shields panel improvements brave/brave-core
9 participants
@tildelowengrimm @bbondy @karenkliu @kjozwiak @cezaraugusto @rebron @srirambv @LaurenWags @btlechowski