Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Wallet button on Tor/Private windows #19096

Closed
srirambv opened this issue Oct 29, 2021 · 1 comment · Fixed by brave/brave-core#10773
Closed

Disable Wallet button on Tor/Private windows #19096

srirambv opened this issue Oct 29, 2021 · 1 comment · Fixed by brave/brave-core#10773

Comments

@srirambv
Copy link
Contributor

Description

Following up on #18455, we should disable the wallet buttons on private and Tor windows similar to rewards button. we can revert this change once window.ethereum is enabled on Tor/Private windows

cc: @jamesmudgett @bbondy

@bbondy bbondy changed the title Disable Wallet button on Tor/Private windows Disable Wallet button on Tor windows Oct 29, 2021
@bbondy bbondy self-assigned this Oct 29, 2021
@bbondy bbondy changed the title Disable Wallet button on Tor windows Disable Wallet button on Tor/Private windows Oct 29, 2021
@bbondy bbondy added this to the 1.33.x - Nightly milestone Oct 29, 2021
@stephendonner
Copy link

stephendonner commented Nov 8, 2021

Verified PASSED using

Brave 1.32.94 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Windows 10 Version 20H2 (Build 19042.1288)

Confirmed there are no wallet icons on Guest, Private, and Private with Tor windows.

Guest Private Private with Tor
guest private private-tor

Verified PASSED using

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS macOS Version 11.6.1 (Build 20G224)

Confirmed there are no wallet icons on Guest, Private, and Private with Tor windows.

Guest Private Private with Tor
Screen Shot 2021-11-15 at 3 13 13 PM Screen Shot 2021-11-15 at 3 13 27 PM Screen Shot 2021-11-15 at 3 13 05 PM

Verified PASSED using

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Linux

Confirmed there are no wallet icons on Guest, Private, and Private with Tor windows.

Guest Private Private with Tor
Screen Shot 2021-11-15 at 3 36 58 PM Screen Shot 2021-11-15 at 3 36 47 PM Screen Shot 2021-11-15 at 3 36 52 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment