Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custodian mismatch notice inconsistent between Rewards panel and Tipping banner #19118

Closed
Miyayes opened this issue Oct 30, 2021 · 1 comment
Closed

Custodian mismatch notice inconsistent between Rewards panel and Tipping banner #19118

Miyayes opened this issue Oct 30, 2021 · 1 comment
Assignees
@zenparsing
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. rewards-2.0

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 30, 2021 •
edited
Loading

Description

Example:

image

Compare to tipping banner:

image

And then the inverse:

image

image

Brave 1.31.88 Chromium: 95.0.4638.69 (Official Build) (x86_64)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS macOS Version 11.5.2 (Build 20G95)
@Miyayes Miyayes changed the title Mismatch custodian tipping path notice not showing on dropdown panel but showing on Tipping banner Custodian mismatch notice not showing on dropdown panel but showing on Tipping banner Oct 30, 2021
@Miyayes Miyayes changed the title Custodian mismatch notice not showing on dropdown panel but showing on Tipping banner Custodian mismatch notice inconsistent between Rewards panel and Tipping banner Oct 30, 2021
@zenparsing zenparsing self-assigned this Nov 3, 2021
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. needs-investigation A bug not 100% confirmed/fixed labels Jun 1, 2022
@Miyayes Miyayes added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jun 22, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Jun 22, 2022

Seems to be resolved. Could have been just an artificial state that I created.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. rewards-2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zenparsing @Miyayes