When Brave Rewards are disabled, clicking on the link at brave://settings/rewards doesn't launch the rewards panel if the Brave Rewards button is hidden

[Tonev]

Description

If Brave Rewards are disabled, clicking on the link at brave://settings/rewards only begins the rewards processes but wouldn't launch the rewards panel if the Brave Rewards button is hidden via brave://settings/appearance.

Steps to Reproduce

1. Make sure Brave Rewards are disabled.
2. Hide the Brave Rewards button via brave://settings/appearance.
3. Open brave://settings/rewards.
4. Click on Click here to learn more.

Actual result:

The Brave Rewards panel wouldn't show up, as per #18158.

Expected result:

Clicking on the link should launch the rewards panel as per #18158.

Reproduces how often:

Easily reproduced.

Brave version (brave://version info)

Brave	1.33.57 Chromium: 95.0.4638.69 (Official Build) nightly (64-bit)
Revision	6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS	Windows 7 Service Pack 1 (Build 7601)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@Miyayes @emerick

[stephendonner]

@Tonev would you mind trying an upgrade from 1.31.87 -> 1.32.x, if you have time?

[Tonev]

@stephendonner

I figured it out just now. The rewards panel wouldn't show up when Hide Brave Rewards button at brave://settings/appearance is enabled.

Updated the whole bug report so developers can take a look and decide whether this works as expected or changes will be required.

[Tonev]

If this is the expected behavior, I don't think clicking on the link should start any Brave Rewards processes if users aren't displayed anything at the time, because users won't understand any new processes have been started unless they check Brave's Task Manager.

[emerick]

@Miyayes Any opinon/thoughts on the correct behavior in this situation (i.e., how do we handle clicking Start Rewards in brave://settings/rewards when the user has the Rewards button hidden)?

[Miyayes]

@Miyayes Any opinon/thoughts on the correct behavior in this situation (i.e., how do we handle clicking Start Rewards in brave://settings/rewards when the user has the Rewards button hidden)?

Is it possible to temporarily enable it, pop it open, and once Rewards is enabled and onboarding is complete, hide it again?

[emerick]

@Miyayes Yep, and in fact, I think we do something like that in other similar situations.

[Miyayes]

@Tonev Is this still an issue on latest Nightly (e.g., 1.46.x+)? Things have changed a bunch since this was filed.

[Miyayes]

Closing as stale. Please refile if you see this again in more recent versions of Brave.