Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UserActivity study defaults to match the Griffin seed #19173

Closed
tmancey opened this issue Nov 2, 2021 · 2 comments · Fixed by brave/brave-core#15414
Closed

Update UserActivity study defaults to match the Griffin seed #19173

tmancey opened this issue Nov 2, 2021 · 2 comments · Fixed by brave/brave-core#15414
Assignees
Labels
dev-concern enhancement feature/ads needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 2, 2021

        {
            "name": "BraveAds.UserActivityStudy",
            "experiments": [
                {
                    "name": "Triggers=NTPSI/TimeWindow=15m/Threshold=0.0/IdleTimeThreshold=5s",
                    "probability_weight": 100,
                    "parameters": [
                        {
                            "name": "triggers",
                            "value": "0D0B14110D0B14110D0B14110D0B1411=-1.0;0D0B1411070707=-1.0;07070707=-1.0"
                        },
                        {
                            "name": "time_window",
                            "value": "15m"
                        },
                        {
                            "name": "threshold",
                            "value": "0.0"
                        },
                        {
                            "name": "idle_time_threshold",
                            "value": "5s"
                        }
                    ],
                    "feature_association": {
                        "enable_feature": ["UserActivity"]
                    }
                },
                {
                    "name": "Default",
                    "probability_weight": 0
                }
            ],
            "filter": {
                "channel": ["NIGHTLY", "BETA", "RELEASE"],
                "platform": ["WINDOWS", "MAC", "LINUX", "ANDROID"]
            }
        },
@tmancey tmancey added enhancement needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. feature/ads OS/Desktop labels Nov 2, 2021
@tmancey
Copy link
Contributor Author

tmancey commented Nov 2, 2021

Before deprecating studies where the feature is enabled by default we should ensure that all users, especially Android users, have proper feature values in the code across all platforms. If the feature is disabled by default then we should test that the default values are working as expected

@tmancey tmancey changed the title Deprecate BraveAds.UserActivityStudy griffin study Update UserActivity study defaults to match the Griffin seed Oct 11, 2022
@tmancey tmancey self-assigned this Oct 11, 2022
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. dev-concern and removed blocked labels Oct 11, 2022
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 12, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.46.83 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS Ubuntu 18.04 LTS

Verified default values for User Activity are:

threshold = 0
time window = 15 minute

[2437:2437:1030/234115.718716:VERBOSE6:user_activity_manager.cc(49)] Triggered event: 02 (0:0:900 s)

Idle Time Threshold = 5 seconds

[2437:2437:1030/234355.946093:VERBOSE1:browser_manager.cc(138)] Browser did enter foreground
[2437:2437:1030/234355.946332:VERBOSE6:user_activity_manager.cc(49)] Triggered event: 01 (0:0:900 s)
[2437:2437:1030/234402.110286:VERBOSE1:idle_detection_manager.cc(66)] User is idle
[2437:2437:1030/234403.148564:VERBOSE1:idle_detection_manager.cc(56)] User is active after 5 s

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern enhancement feature/ads needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants