Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Auto Focusing on Input Elements Throughout Wallet #19326

Closed
Douglashdaniel opened this issue Nov 9, 2021 · 1 comment · Fixed by brave/brave-core#11348
Closed

Improve Auto Focusing on Input Elements Throughout Wallet #19326

Douglashdaniel opened this issue Nov 9, 2021 · 1 comment · Fixed by brave/brave-core#11348
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.35.x - Release

Comments

@Douglashdaniel
Copy link

Description

Improve Auto Focusing on Input Elements Throughout Wallet

When clicking on Visible assets, should focus the search box.
When clicking on an asset in the Send tab of the send widget, should focus the textbook there.
When clicking on Add account, should focus edit box there
etc…
@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 9, 2021
@Douglashdaniel Douglashdaniel self-assigned this Nov 9, 2021
@Douglashdaniel Douglashdaniel mentioned this issue Nov 29, 2021
Closed
@muliswilliam muliswilliam mentioned this issue Nov 30, 2021
Merged
24 tasks
@muliswilliam muliswilliam added this to the 1.35.x - Nightly milestone Dec 3, 2021
@srirambv
Copy link
Contributor

Brave 1.35.89 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified clicking on visible assets opens the asset modal and focus is set to the search box
  • Verified clicking on Buy/Send/Swap on the widget sets focus on the input value field
  • Verified selecting adding an account sets focus on the Account name field and cursor is at the end of the pre-filled account name

@kjozwiak kjozwiak mentioned this issue Feb 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

Improve Auto Focusing on Input Elements Throughout Wallet brave/brave-core
4 participants
@bbondy @srirambv @Douglashdaniel @muliswilliam