Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archives brave-<version>-win32-x64.zip (with windows release builds) are broken #19344

Closed
atuchin-m opened this issue Nov 10, 2021 · 6 comments · Fixed by brave/brave-core#11170

Comments

@atuchin-m
Copy link
Contributor

The zip archives brave-<version>-win32-x64.zip from https://github.com/brave/brave-browser/releases/ are broken.
The chrome.dll and some other resources are missed => the browser fails to start.
Also:

  1. The size much is less than standalone installed (~37MB vs 84MB, but should be near the same)
  2. The problem isn't new. A year-old (Dec 2020) brave-v1.20.12-win32-x64.zip is also broken

image (3)

@rebron
Copy link
Collaborator

rebron commented Nov 10, 2021

cc: @mihaiplesa @brave/legacy_qa

@rebron rebron added needs-investigation A bug not 100% confirmed/fixed OS/Windows labels Nov 10, 2021
@mihaiplesa
Copy link
Contributor

We just upload the archives in the pipelines so we'd need someone to look at the browser code generating them.

@atuchin-m
Copy link
Contributor Author

Here is the code that create the archive: https://github.com/brave/brave-core/blob/master/BUILD.gn#L370

@LaurenWags
Copy link
Member

@atuchin-m can QA get a test plan for this one please? cc @rebron

if no manual QA is needed, we can change this to QA/No.

@atuchin-m
Copy link
Contributor Author

You simply to download the recent win zip and check that it works (without any other brave instalation on the computer).

https://github.com/brave/brave-browser/releases

@stephendonner
Copy link

Verified PASSED on both

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 10 Version 20H2 (Build 19042.1415)

--and--

Brave 1.34.63 Chromium: 96.0.4664.110 (Official Build) (64-bit)
Revision d5ef0e8214bc14c9b5bbf69a1515e431394c62a6-refs/branch-heads/4664@{#1283}
OS Windows 11 Version 21H2 (Build 22000.348)

Steps:

  1. downloaded https://github.com/brave/brave-browser/releases/download/v1.34.63/brave-v1.34.63-win32-x64.zip
  2. extracted to Downloads
  3. ran the brave.exe from the above folder
  4. confirmed I could use the browser
Windows 10 Windows 11
file-archive-windows10 file-archive-windows11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants