Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message persists even when trying to perform a different action #19353

Closed
srirambv opened this issue Nov 10, 2021 · 1 comment · Fixed by brave/brave-core#11176
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Error message persists even when trying to perform a different action

Steps to Reproduce

  1. Connect Ledger device and trigger an error message
  2. Try to connect to Trezor
  3. Ledger message continues to show and is not dismissed

Actual result:

Persistent.Error.message.mp4

Expected result:

Should dismiss the error message when a different action is being performed like selecting a different h/w wallet

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.95 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @spylogsster @jamesmudgett

@srirambv
Copy link
Contributor Author

Brave 1.33.90 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22504.1010)
☑️ macOS Version 12.0.1
(Build 21A559)
  • Verified steps from issue description
  • Verified error message is not persistent when a selection is made
19353.-.Linux.mp4
19353.-.Windows.mov
19353.-.macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants