Article timestamp differs in nightly and release

[stephendonner]

Description

Article timestamp differs in nightly and release

Steps to Reproduce

1. new profile
2. launch Brave
3. load https://www.indy100.com/news/subway-tuna-cattle-pork-chicken-b1956078
4. enable Speedreader mode
5. look at the article's timestamp

Actual result:

Expected result:

Perhaps the timestamp when viewed in release?

Reproduces how often:

100% on this site

Brave version (brave://version info)

Brave	1.34.10 Chromium: 96.0.4664.45 (Official Build) nightly (arm64)
Revision	76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS	macOS Version 11.6 (Build 20G165)

/cc @rillian

[stephendonner]

Or is this actually not a bug, since showing 12-hour time might be preferred to 24-hour timestamps? When I posted this in Slack, I said nightly vs. prod (in that order), but the screenshots shown were presented in reverse order, so could have been misleading.

[Tonev]

@stephendonner

If the idea is to use 24-hour clock, there shouldn't be AM and PM, so even if that is the intention, there is still room for improvement so your issue is still a valid one for me 👍

[rillian]

Ok, thanks for filing the issue. Having checked the code against the screenshots more carefully, I think this is not in fact a bug. brave/brave-core#10965 switched from a 24- to 12-hour clock representation, but if we're posting am/pm, that's more appropriate.

It is a bug that this format is hard-coded instead of using the current locale, but that's not a regression, so I don't consider it urgent. I filed #19452 to follow up.