Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the number of rejected transactions that is shown on transaction page #19441

Closed
srirambv opened this issue Nov 15, 2021 · 2 comments · Fixed by brave/brave-core#15544
Closed

Limit the number of rejected transactions that is shown on transaction page #19441

srirambv opened this issue Nov 15, 2021 · 2 comments · Fixed by brave/brave-core#15544
Assignees
@josheleonard
Labels
design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include suggestion
Milestone
1.47.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 15, 2021 •
edited by onyb
Loading

Description

Decide if we need to show rejected transactions in transaction history or not

@onyb Update: After some internal discussions, we decided to limit the number of rejected transactions. Additionally, the limits for rejected transactions could be lower than completed transactions, due to storage restrictions.

Steps to Reproduce

  1. Initiate a transaction
  2. Reject the transaction via panel
  3. Open transactions and click on the view block explorer via the menu button, shows error message

Actual result:

image

Expected result:

TBA

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.103 Chromium: 96.0.4664.45 (Official Build) (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc; @jamesmudgett @bbondy
@srirambv srirambv added suggestion design A design change, especially one which needs input from the design team QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 15, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 15, 2021
@srirambv srirambv changed the title Decide if we need to show rejected transactions in transaction history or not Limit the number of rejected transactions that is shown on transaction page Nov 16, 2021
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 18, 2022
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Backlog in Web3 Mar 18, 2022
@josheleonard
Copy link

What criteria do we want to use for deciding if a rejected transaction should be displayed or hidden?
cc @jamesmudgett @onyb

@josheleonard josheleonard self-assigned this Oct 19, 2022
@josheleonard josheleonard moved this from Backlog to In Progress in Web3 Oct 19, 2022
@josheleonard josheleonard mentioned this issue Oct 19, 2022
Merged
25 tasks
@josheleonard josheleonard moved this from In Progress to In Review in Web3 Oct 19, 2022
Repository owner moved this from In Review to Done in Web3 Oct 21, 2022
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 21, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Dec 5, 2022

Verification passed on

Brave 1.47.108 Chromium: 108.0.5359.71 (Official Build) beta (64-bit)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS Linux
  • Verified steps from brave/brave-core#15544
  • Verified only submitted transactions are listed
  • Verified none of the rejected transactions are shown
19441.mp4

Verification passed on

Brave 1.47.108 Chromium: 108.0.5359.71 (Official Build) beta (64-bit)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#15544
  • Verified only submitted transactions are listed
  • Verified none of the rejected transactions are shown
19441.mp4

Verification passed on

Brave 1.47.108 Chromium: 108.0.5359.71 (Official Build) beta (arm64)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#15544
  • Verified only submitted transactions are listed
  • Verified none of the rejected transactions are shown
19441.mov

@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include suggestion
Projects
Web3
Archived in project
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

fix: hide rejected transactions in UI brave/brave-core
4 participants
@bbondy @srirambv @josheleonard @brave-builds