Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove crypto widgets from Desktop and Android #19478

Closed
bbondy opened this issue Nov 16, 2021 · 4 comments
Closed

Remove crypto widgets from Desktop and Android #19478

bbondy opened this issue Nov 16, 2021 · 4 comments
Assignees
@deeppandya @simonhong
Labels
closed/duplicate Issue has already been reported
Milestone
1.33.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Nov 16, 2021 •
edited by simonhong
Loading

This issue is to track removing the crypto widgets from the new tab page.
They should retire to the gallery for Desktop.

On Desktop this includes: #19708

  • Binance
  • Gemini
  • FTX
  • Crypto.com

On Android this includes:

  • Binance
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 16, 2021
@bbondy bbondy added this to the 1.33.x - Beta milestone Nov 16, 2021
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 16, 2021
@deeppandya
Copy link
Contributor

@bbondy issue for removing binance widget on andrioid : #19546
this issue also includes changes from desktop so i thought of creating specific for android.

@deeppandya
Copy link
Contributor

PR for android changes : brave/brave-core#11148

@deeppandya deeppandya mentioned this issue Nov 18, 2021
Closed
@bsclifton bsclifton mentioned this issue Nov 22, 2021
Closed
@simonhong simonhong mentioned this issue Nov 24, 2021
Closed
@simonhong
Copy link
Member

@bbondy I think we can close this as all PRs for desktop and android are merged?
Desktop: brave/brave-core#11266
Android: brave/brave-core#11148

@bbondy
Copy link
Member Author

bbondy commented Nov 25, 2021

Closing as dupe of #19708

@bbondy bbondy closed this as completed Nov 25, 2021
@bbondy bbondy added the closed/duplicate Issue has already been reported label Nov 25, 2021
@LaurenWags LaurenWags removed release/blocking priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

@simonhong simonhong

Labels
closed/duplicate Issue has already been reported
Projects
None yet
Milestone
1.33.x - Release
Development

No branches or pull requests
5 participants
@bbondy @deeppandya @rebron @simonhong @LaurenWags