Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdfium not fully blocked on Linux #1958

Closed
diracdeltas opened this issue Nov 1, 2018 · 11 comments
Closed

pdfium not fully blocked on Linux #1958

diracdeltas opened this issue Nov 1, 2018 · 11 comments

Comments

@diracdeltas
Copy link
Member

STR:

  1. try the repro steps from PDFs fail to load if behind basic auth #1788 on Linux
  2. notice that instead of prompting you to download the PDF, it loads in Chrome's PDF viewer (pdfium)
@diracdeltas diracdeltas added security priority/P3 The next thing for us to work on. It'll ride the trains. extension/PDFJS OS/Linux labels Nov 1, 2018
@darkdh
Copy link
Member

darkdh commented Nov 1, 2018

screen shot 2018-11-01 at 10 49 00

screen shot 2018-11-01 at 10 58 38

component is also showing enable in both `brave://extensions` and `brave://net-internals/#modules`

@yrliou yrliou self-assigned this Nov 1, 2018
@diracdeltas diracdeltas added the bug label Nov 1, 2018
@yrliou
Copy link
Member

yrliou commented Nov 2, 2018

Seems like it is not always happening because I could not reproduce it on 0.55.22 using Ubuntu 18.04. Chromium PDF Viewer is disabled for me and the STR would prompt me to download the PDF.

@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@bbondy
Copy link
Member

bbondy commented Nov 5, 2018

Can anyone reproduce this with c71 and beyond?

@diracdeltas
Copy link
Member Author

diracdeltas commented Nov 6, 2018

It was repro'ed by anonymous on Linux with 0.55.x master. I do not know of anyone who has tested this on c71 and above.

@yrliou yrliou removed their assignment Nov 6, 2018
@tildelowengrimm
Copy link
Contributor

@kjozwiak Can you check to see if this still repros?

@kjozwiak
Copy link
Member

This is what I'm seeing when using 0.57.7 Chromium: 71.0.3578.53 under Ubuntu 18.04 x64 VM:

linuxpdf

What basically happens is that when I initially authenticate, it uses Chrome's PDF viewer (pdfium), however re-loading it again after the authentication loads the PDF within PDFJS. Chrome's PDF viewer (pdfium) seems to be enabled under brave://extensions as well.

@diracdeltas
Copy link
Member Author

@yrliou based on what @kjozwiak posted above, it appears the original bug is still in c71

@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 29, 2018
@bbondy
Copy link
Member

bbondy commented Nov 29, 2018

upping this to p2

@fmarier
Copy link
Member

fmarier commented Jan 10, 2019

Based on brave/brave-core#980 (comment), I don't think we can disable PDFium entirely. I'll have to dig into why it gets picked up for PDFs behind auth.

@fmarier
Copy link
Member

fmarier commented Jan 29, 2019

By following the repro steps, I was able to see PDFium in these versions:

  • Version 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta (64-bit)
  • Version 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit)

but not in these ones:

  • Version 0.58.9 Chromium: 71.0.3578.53 (Official Build) dev (64-bit)
  • Version 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
  • Version 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)

So as far as I can tell, this problem was fixed in 0.58.

@fmarier fmarier closed this as completed Jan 29, 2019
@srirambv
Copy link
Contributor

Moving to Not actionable milestone as its already fixed and release channel migration has already completed.

@srirambv srirambv modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 29, 2019
@kjozwiak kjozwiak added closed/invalid and removed OS/Linux bug extension/PDFJS priority/P2 A bad problem. We might uplift this to the next planned release. security labels Feb 6, 2019
@rebron rebron removed this from the Dupe / Invalid / Not actionable milestone May 10, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants