Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plus button urls is blocked when editing networks #19717

Closed
spylogsster opened this issue Nov 24, 2021 · 2 comments · Fixed by brave/brave-core#11273
Closed

Plus button urls is blocked when editing networks #19717

spylogsster opened this issue Nov 24, 2021 · 2 comments · Fixed by brave/brave-core#11273
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@spylogsster
Copy link

Description

Plus button for RPC urls is blocked when editing networks

Steps to Reproduce

  1. Add custom network
  2. Double click to edit
  3. Check "+" button for RPS urls

Actual result:

The button is blocked

Expected result:

The button is unblocked

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@spylogsster spylogsster self-assigned this Nov 24, 2021
@spylogsster spylogsster changed the title Plus button for RPC urls is blocked when editing networks Plus button urls is blocked when editing networks Nov 24, 2021
@spylogsster spylogsster added this to the 1.34.x - Nightly milestone Nov 25, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 26, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 4, 2021
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 21, 2021
@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.34.68 Chromium: 97.0.4692.56 (Official Build) beta (x86_64)
-- | --
Revision | 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS | macOS Version 11.6.1 (Build 20G224)

Verified STR and test plan from brave/brave-core#11273 (comment).
Confirmed when editing a custom network the "+" for RPC URLs field is visible and can be clicked on.

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 21, 2021
@srirambv
Copy link
Contributor

srirambv commented Jan 3, 2022

Verification passed on

Brave 1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Windows 11 Version Dev (Build 22523.1000)
  • Verified steps from brave/brave-core#11273
  • Verified editing a custom network shows the + button for adding a new RPC URL
  • Verified clicking on the + button in edit mode hides the button for adding a new URL
  • Verified adding a valid URL brings back the + button to focus
Windows.mov

Verification passed on

Brave 1.34.77 Chromium: 97.0.4692.56 (Official Build) (64-bit)
Revision 04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS Linux
  • Verified steps from brave/brave-core#11273
  • Verified editing a custom network shows the + button for adding a new RPC URL
  • Verified clicking on the + button in edit mode hides the button for adding a new URL
  • Verified adding a valid URL brings back the + button to focus
Linux.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants