Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme related issues on Android Wallet #19827

Closed
srirambv opened this issue Nov 30, 2021 · 1 comment · Fixed by brave/brave-core#11753
Closed

Theme related issues on Android Wallet #19827

srirambv opened this issue Nov 30, 2021 · 1 comment · Fixed by brave/brave-core#11753
Assignees
@Pavneet-Sing
Labels
feature/themes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 30, 2021 •
edited
Loading

Description

Theme related issues on Android Wallet

Actual result

Place holder text's are not clearly visible on dark theme

Restore Screen Search box Restore Seed Warning message
image image image

Expected result

Clear visible text on dark theme

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): ALL
  • Android version: ALL

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc: @wchen342 @SergeyZhukovsky
@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support feature/themes OS/Android Fixes related to Android browser functionality labels Nov 30, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 30, 2021
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 4, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 5, 2022
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing added this to the 1.36.x - Nightly milestone Jan 10, 2022
@srirambv
Copy link
Contributor Author

srirambv commented Feb 4, 2022

Verification passed on Oppo Reno 5 with Android 11 running 1.36.85 x64 beta build

  • Verified text is properly visible on dark theme for Restore Wallet & Restore Seed Warning message
  • Verified text is still properly visible on light theme as well

Verification passed on Samsung Tab A with Android 10 running 1.36.85 x64 beta build

  • Verified text is properly visible on dark theme for Restore Wallet & Restore Seed Warning message
  • Verified text is still properly visible on light theme as well

@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/themes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): replace-dark-theme-hint-text-colors brave/brave-core
3 participants
@bbondy @Pavneet-Sing @srirambv